You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/26 22:37:59 UTC

[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #3207: [GOBBLIN-1386] Make gobblin yarn application be able to add zip fils as local resources, and make yarn class path to be configurable

ZihanLi58 commented on a change in pull request #3207:
URL: https://github.com/apache/incubator-gobblin/pull/3207#discussion_r564882352



##########
File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnConfigurationKeys.java
##########
@@ -124,4 +126,5 @@
   public static final String GOBBLIN_YARN_AZKABAN_CLASS_LOG_LEVELS = GOBBLIN_YARN_PREFIX + "azkaban.class.logLevels";
   //Container classpaths properties
   public static final String GOBBLIN_YARN_ADDITIONAL_CLASSPATHS = GOBBLIN_YARN_PREFIX + "additional.classpaths";
+  public static final String GOBBLIN_YARN_CLASSPATHS = GOBBLIN_YARN_PREFIX + "classpaths";

Review comment:
       Additional path is to add new class path on the default one which is set the the yarn config. And in our case, we need to overwrite the default config to a different class path, so I just add a new config and keep the old one for backward compatibility and support more flexible use case. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org