You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/09 07:28:06 UTC
[GitHub] [cassandra] nastra opened a new pull request #528: Update docs
describing when a CHANGES.txt entry is necessary
nastra opened a new pull request #528: Update docs describing when a CHANGES.txt entry is necessary
URL: https://github.com/apache/cassandra/pull/528
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] nastra commented on a change in pull request #528:
Update docs describing when a CHANGES.txt entry is necessary
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #528: Update docs describing when a CHANGES.txt entry is necessary
URL: https://github.com/apache/cassandra/pull/528#discussion_r406017971
##########
File path: doc/source/development/patches.rst
##########
@@ -108,7 +108,7 @@ So you've finished coding and the great moment arrives: it's time to submit your
a. Attach a patch to JIRA with a single squashed commit in it (per branch), or
b. Squash the commits in-place in your branches into one
- 6. Include a CHANGES.txt entry (put it at the top of the list), and format the commit message appropriately in your patch as below.
+ 6. Include a CHANGES.txt entry (put it at the top of the list), and format the commit message appropriately in your patch as below. Please note that only user-impacting items should be listed in CHANGES.txt. If you fix a test that does not affect users and does not require changes in runtime code, then no CHANGES.txt entry is necessary.
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request
#528: Update docs describing when a CHANGES.txt entry is necessary
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #528: Update docs describing when a CHANGES.txt entry is necessary
URL: https://github.com/apache/cassandra/pull/528#discussion_r406012456
##########
File path: doc/source/development/patches.rst
##########
@@ -108,7 +108,7 @@ So you've finished coding and the great moment arrives: it's time to submit your
a. Attach a patch to JIRA with a single squashed commit in it (per branch), or
b. Squash the commits in-place in your branches into one
- 6. Include a CHANGES.txt entry (put it at the top of the list), and format the commit message appropriately in your patch as below.
+ 6. Include a CHANGES.txt entry (put it at the top of the list), and format the commit message appropriately in your patch as below. Please note that only user-impacting items should be listed in CHANGES.txt. If you fix a test that does not affect users and does not require changes in runtime code, then no CHANGES.txt entry is necessary.
Review comment:
can you hyperlink the word `should` to https://lists.apache.org/thread.html/rde1128131a621e43b0a9c88778398c053a234da0f4c654b82dcbbe0e%40%3Cdev.cassandra.apache.org%3E so institutional knowledge and the background is preserved…?
(or i can do it during the merge if you prefer)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on issue #528: Update docs
describing when a CHANGES.txt entry is necessary
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on issue #528: Update docs describing when a CHANGES.txt entry is necessary
URL: https://github.com/apache/cassandra/pull/528#issuecomment-612183587
Committed as https://github.com/apache/cassandra/commit/141ea26733e7e8fe022bc78f7fd68225013e8d14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever closed pull request #528: Update docs
describing when a CHANGES.txt entry is necessary
Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #528: Update docs describing when a CHANGES.txt entry is necessary
URL: https://github.com/apache/cassandra/pull/528
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on issue #528: Update docs
describing when a CHANGES.txt entry is necessary
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on issue #528: Update docs describing when a CHANGES.txt entry is necessary
URL: https://github.com/apache/cassandra/pull/528#issuecomment-612175058
> I think I will add a commit here that also cleans up CHANGES.txt
done w/ https://github.com/apache/cassandra/commit/0e68f944f439de44f9d40e7d4e7c440a1ae95e12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org