You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/25 15:28:16 UTC

[GitHub] [arrow] eerhardt commented on pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

eerhardt commented on pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#issuecomment-619396229


   > ARROW-5634 by properly setting the readonly value for NullCount, which previously was hardcoded to -1.
   
   I don't believe this change addresses the issue correctly. Can we remove that one from this PR? We can submit a separate PR for ARROW-5634, since it would involve more work and I think this PR should be targeted to just the ArrayBuilder API to support appending `null`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org