[GitHub] [hadoop] mehakmeet commented on a change in pull request #3292: HADOOP-13887. Support S3 client side encryption (S3-CSE) using AWS-SDK

[GitBox <gi...@apache.org>]

mehakmeet commented on a change in pull request #3292:
URL: https://github.com/apache/hadoop/pull/3292#discussion_r770366967



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -415,12 +422,16 @@ public void initialize(URI name, Configuration originalConf)
       // DT Bindings may override this
       setEncryptionSecrets(new EncryptionSecrets(
           getEncryptionAlgorithm(bucket, conf),
-          getServerSideEncryptionKey(bucket, getConf())));
+          getS3EncryptionKey(bucket, getConf())));
 
       invoker = new Invoker(new S3ARetryPolicy(getConf()), onRetry);
       instrumentation = new S3AInstrumentation(uri);
       initializeStatisticsBinding();
-
+      // If CSE-KMS method is set then CSE is enabled.
+      isCSEEnabled = S3AUtils.lookupPassword(conf,

Review comment:
       Hey @balvisio. Yes, this was incorrect and fixed in subsequent patches related to S3A CSE. In the current branch it's:
   ```
   isCSEEnabled = S3AEncryptionMethods.CSE_KMS.getMethod()
             .equals(getS3EncryptionAlgorithm().getMethod());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org