[GitHub] [iceberg] rdblue commented on a change in pull request #4147: Support planning with particular executor for snapshots update

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #4147:
URL: https://github.com/apache/iceberg/pull/4147#discussion_r810656493



##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -248,7 +247,7 @@ private void performRewrite(List<ManifestFile> currentManifests) {
             }
           });
     } finally {
-      Tasks.foreach(writers.values()).executeWith(ThreadPools.getWorkerPool()).run(WriterWrapper::close);
+      Tasks.foreach(writers.values()).executeWith(planExecutorService()).run(WriterWrapper::close);
     }

Review comment:
       I agree. The executor service is owned elsewhere.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org