You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/02/26 06:30:22 UTC
[GitHub] zeppelin pull request #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should ...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2069
[ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain ZEPPELIN_CONF_DIR
### What is this PR for?
ZEPPELIN_INTP_CLASSPATH should contain ZEPPELIN_CONF_DIR so if in case of "core-site.xml", "hbase-site.xml" etc. present locally can be read from there itself.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-2177](https://issues.apache.org/jira/browse/ZEPPELIN-2177)
### How should this be tested?
After running any of the paragraph
then on doing a `ps aux | grep interpreter.sh` in "-cp" observe Zeppelin's conf directory path
<pre>
$ ps aux | grep interpreter.sh
prabhjyotsingh 25175 0.1 0.5 5015500 78976 s001 S 11:52AM 0:00.93 /Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home/bin/java -Dfile.encoding=UTF-8 -Dlog4j.configuration=file:///Users/prabhjyotsingh/ps-zeppelin/conf/log4j.properties -Dzeppelin.log.file=/Users/prabhjyotsingh/ps-zeppelin/logs/zeppelin-interpreter-sh-prabhjyotsingh-HW11610.local.log -Xms1024m -Xmx1024m -XX:MaxPermSize=512m -cp ::/Users/prabhjyotsingh/ps-zeppelin/interpreter/sh/*:/Users/prabhjyotsingh/ps-zeppelin/zeppelin-interpreter/target/lib/*::/Users/prabhjyotsingh/ps-zeppelin/zeppelin-interpreter/target/classes:/Users/prabhjyotsingh/ps-zeppelin/zeppelin-interpreter/target/test-classes:/Users/prabhjyotsingh/ps-zeppelin/zeppelin-zengine/target/test-classes:<b>/Users/prabhjyotsingh/ps-zeppelin/conf</b> org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer 62196
prabhjyotsingh 25186 0.0 0.0 2442028 820 s001 S+ 11:52AM 0:00.00 grep interpreter.sh
prabhjyotsingh 25174 0.0 0.0 2462072 760 s001 S 11:52AM 0:00.00 /bin/bash /Users/prabhjyotsingh/ps-zeppelin/bin/interpreter.sh -d /Users/prabhjyotsingh/ps-zeppelin/interpreter/sh -p 62196 -l /Users/prabhjyotsingh/ps-zeppelin/local-repo/2C8YBAR9B
prabhjyotsingh 25166 0.0 0.0 2452856 1280 s001 S 11:52AM 0:00.01 /bin/bash /Users/prabhjyotsingh/ps-zeppelin/bin/interpreter.sh -d /Users/prabhjyotsingh/ps-zeppelin/interpreter/sh -p 62196 -l /Users/prabhjyotsingh/ps-zeppelin/local-repo/2C8YBAR9B
</pre>
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2177
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2069.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2069
----
commit 5041b1cdb79952aca64f74033bca0c3f8f7d8999
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-26T06:08:03Z
ZEPPELIN-2177: ZEPPELIN_INTP_CLASSPATH should contain ZEPPELIN_CONF_DIR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2069
Sure, let me check. I wasn't aware.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2069
AFAIK, it was removed before because someone blame log4j.properties location. Do you know the history? Personally, I agree that it includes conf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2069
Sure, let me check. I wasn't aware.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2069
I think you are right. I'll close this, and use `ZEPPELIN_INTP_CLASSPATH_OVERRIDES` and use a different path where ever it is really required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2069
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2069
Thank you @felixcheung and @jongyoul for the quick feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---