[jira] [Commented] (CASSANDRA-9510) assassinating an unknown endpoint could npe

["Joel Knighton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-9510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022523#comment-15022523 ] 

Joel Knighton commented on CASSANDRA-9510:
------------------------------------------

Thanks for this patch - sorry for the delay in getting review.

Since the time the patch was posted, we changed how we access the partitioner in [CASSANDRA-8143].  I made small changes to accommodate this in the provided patch.

||branch||testall||dtest||
|[9510-3.0|https://github.com/jkni/cassandra/tree/9510-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-9510-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-9510-3.0-dtest]|

CI looks clean. 

+1. Please use the patch labeled v2/the branch in this comment on commit. It should merge cleanly up to 3.1 and trunk.

> assassinating an unknown endpoint could npe
> -------------------------------------------
>
>                 Key: CASSANDRA-9510
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9510
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 3.0.1, 3.1
>
>         Attachments: assissinate_unknown.txt
>
>
> If the code assissinates an unknown endpoint, it doesn't generate a 'tokens' collection, which then does
> epState.addApplicationState(ApplicationState.STATUS, StorageService.instance.valueFactory.left(tokens, computeExpireTime()));
> and left(null, time); will npe



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)