You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2017/03/12 16:33:37 UTC

[3/5] logging-log4j2 git commit: When suffix is blank, it won't be appended

When suffix is blank, it won't be appended


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/d9c9dd9a
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/d9c9dd9a
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/d9c9dd9a

Branch: refs/heads/master
Commit: d9c9dd9aa8c0eb3ef422fb7f942f804b21d8dbb7
Parents: 54b6c88
Author: xnslong <xn...@outlook.com>
Authored: Fri Mar 10 01:02:44 2017 +0800
Committer: xnslong <xn...@outlook.com>
Committed: Fri Mar 10 01:02:44 2017 +0800

----------------------------------------------------------------------
 .../logging/log4j/core/pattern/ThrowablePatternConverter.java | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d9c9dd9a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java
index bcd631a..da20713 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java
@@ -183,10 +183,13 @@ public class ThrowablePatternConverter extends LogEventPatternConverter {
             final StringBuilder sb = new StringBuilder();
             final String[] array = w.toString().split(Strings.LINE_SEPARATOR);
             final int limit = options.minLines(array.length) - 1;
+            final boolean suffixNotBlank = Strings.isNotBlank(suffix);
             for (int i = 0; i <= limit; ++i) {
                 sb.append(array[i]);
-                sb.append(' ');
-                sb.append(suffix);
+                if (suffixNotBlank) {
+                    sb.append(' ');
+                    sb.append(suffix);
+                }
                 if (i < limit) {
                     sb.append(options.getSeparator());
                 }