[GitHub] [beam] ibzib commented on a change in pull request #14035: [BEAM-11849] Support ARRAY_CONCAT_AGG fn for Zetasql dialect

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #14035:
URL: https://github.com/apache/beam/pull/14035#discussion_r583044780



##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -91,6 +92,12 @@
           x -> createTypeFactory().createArrayType(x.getOperandType(0), -1),
           new UdafImpl<>(new ArrayAgg.ArrayAggArray()));
 
+  public static final SqlOperator ARRAY_CONCAT_AGG_FN =
+      createUdafOperator(
+          "array_concat_agg",
+          x -> createTypeFactory().createArrayType(x.getOperandType(0), -1),

Review comment:
       I'm pretty sure the problem is with this line here. The return type is supposed to be ARRAY<BIGINT>, but the type returned here is ARRAY<ARRAY<BIGINT>>. I'm guessing it's because `x.getOperandType(0)` is an array type. Instead it should be the type of elements inside `x.getOperandType(0)`. (I'm not sure exactly what the method is to get that, but you should be able to figure it out using the debugger.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org