[GitHub] [gobblin] ZihanLi58 commented on a diff in pull request #3711: [GOBBLIN-1847] Exceptions in the JobLauncher should try to delete the existing workflow if it is launched

["ZihanLi58 (via GitHub)" <gi...@apache.org>]

ZihanLi58 commented on code in PR #3711:
URL: https://github.com/apache/gobblin/pull/3711#discussion_r1244327913


##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java:
##########
@@ -462,10 +466,14 @@ public void launchJob(@Nullable JobListener jobListener) throws JobException {
       }
 
       // TODO: Better error handling. The current impl swallows exceptions for jobs that were started by this method call.
-      // One potential way to improve the error handling is to make this error swallowing conifgurable
+      // One potential way to improve the error handling is to make this error swallowing configurable
     } catch (Throwable t) {
       errorInJobLaunching = t;
     } finally {
+      if (isCancelWorkflowOnExitEnabled) {
+        cancelJob(jobListener);

Review Comment:
   I'm not getting the idea to put this under the final block and add a flag to determine the logic. Can we consider putting it under the catch block and check the value of isLaunched to determine whether we need to cancel the job or not? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org