You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jim Jagielski <ji...@jaguNET.com> on 2013/11/12 13:28:46 UTC
Re: svn commit: r1541029 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/http_core.h modules/loggers/mod_syslog.c server/core.c
On Nov 12, 2013, at 7:14 AM, jkaluza@apache.org wrote:
> Author: jkaluza
> Date: Tue Nov 12 12:14:50 2013
> New Revision: 1541029
>
> URL: http://svn.apache.org/r1541029
> Log:
> Add parse_errorlog_arg callback to ap_errorlog_provider to allow providers
> to check the ErrorLog argument. Implement this check in mod_syslog.
>
> Modified: httpd/httpd/trunk/include/ap_mmn.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_mmn.h?rev=1541029&r1=1541028&r2=1541029&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/include/ap_mmn.h (original)
> +++ httpd/httpd/trunk/include/ap_mmn.h Tue Nov 12 12:14:50 2013
> @@ -441,12 +441,13 @@
> * 20130903.0 (2.5.0-dev) Changes sizeof(worker_score) in scoreboard
> * 20130924.0 (2.5.0-dev) Add ap_errorlog_provider
> * 20130924.1 (2.5.0-dev) Add ap_proxy_connection_reusable()
> + * 20131112.0 (2.5.0-dev) Add parse_errorlog_arg to ap_errorlog_provider
> */
>
> #define MODULE_MAGIC_COOKIE 0x41503235UL /* "AP25" */
>
> #ifndef MODULE_MAGIC_NUMBER_MAJOR
> -#define MODULE_MAGIC_NUMBER_MAJOR 20130924
> +#define MODULE_MAGIC_NUMBER_MAJOR 20131112
> #endif
> #define MODULE_MAGIC_NUMBER_MINOR 1 /* 0...n */
>
>
Why a major bump?
Re: svn commit: r1541029 - in /httpd/httpd/trunk: CHANGES
include/ap_mmn.h include/http_core.h modules/loggers/mod_syslog.c server/core.c
Posted by Jeff Trawick <tr...@gmail.com>.
On Tue, Nov 12, 2013 at 7:40 AM, Jan Kaluža <jk...@redhat.com> wrote:
> On 11/12/2013 01:28 PM, Jim Jagielski wrote:
>
>>
>> On Nov 12, 2013, at 7:14 AM, jkaluza@apache.org wrote:
>>
>> Author: jkaluza
>>> Date: Tue Nov 12 12:14:50 2013
>>> New Revision: 1541029
>>>
>>> URL: http://svn.apache.org/r1541029
>>> Log:
>>> Add parse_errorlog_arg callback to ap_errorlog_provider to allow
>>> providers
>>> to check the ErrorLog argument. Implement this check in mod_syslog.
>>>
>>> Modified: httpd/httpd/trunk/include/ap_mmn.h
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_
>>> mmn.h?rev=1541029&r1=1541028&r2=1541029&view=diff
>>> ============================================================
>>> ==================
>>> --- httpd/httpd/trunk/include/ap_mmn.h (original)
>>> +++ httpd/httpd/trunk/include/ap_mmn.h Tue Nov 12 12:14:50 2013
>>> @@ -441,12 +441,13 @@
>>> * 20130903.0 (2.5.0-dev) Changes sizeof(worker_score) in scoreboard
>>> * 20130924.0 (2.5.0-dev) Add ap_errorlog_provider
>>> * 20130924.1 (2.5.0-dev) Add ap_proxy_connection_reusable()
>>> + * 20131112.0 (2.5.0-dev) Add parse_errorlog_arg to
>>> ap_errorlog_provider
>>> */
>>>
>>> #define MODULE_MAGIC_COOKIE 0x41503235UL /* "AP25" */
>>>
>>> #ifndef MODULE_MAGIC_NUMBER_MAJOR
>>> -#define MODULE_MAGIC_NUMBER_MAJOR 20130924
>>> +#define MODULE_MAGIC_NUMBER_MAJOR 20131112
>>> #endif
>>> #define MODULE_MAGIC_NUMBER_MINOR 1 /* 0...n */
>>>
>>>
>>>
>> Why a major bump?
>>
>>
> Correct me if I'm wrong, but my changes in that commit break binary
> compatibility for modules using the older error log provider API, so I
> thought I'm requested to bump major.
>
> Regards,
> Jan Kaluza
>
>
IOW, the module allocates the space. (It isn't like adding a field to the
end of request_rec.)
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: svn commit: r1541029 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/http_core.h modules/loggers/mod_syslog.c server/core.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
OK, I see now. Thx.
On Nov 12, 2013, at 7:40 AM, Jan Kaluža <jk...@redhat.com> wrote:
> On 11/12/2013 01:28 PM, Jim Jagielski wrote:
>>
>> On Nov 12, 2013, at 7:14 AM, jkaluza@apache.org wrote:
>>
>>> Author: jkaluza
>>> Date: Tue Nov 12 12:14:50 2013
>>> New Revision: 1541029
>>>
>>> URL: http://svn.apache.org/r1541029
>>> Log:
>>> Add parse_errorlog_arg callback to ap_errorlog_provider to allow providers
>>> to check the ErrorLog argument. Implement this check in mod_syslog.
>>>
>>> Modified: httpd/httpd/trunk/include/ap_mmn.h
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_mmn.h?rev=1541029&r1=1541028&r2=1541029&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/include/ap_mmn.h (original)
>>> +++ httpd/httpd/trunk/include/ap_mmn.h Tue Nov 12 12:14:50 2013
>>> @@ -441,12 +441,13 @@
>>> * 20130903.0 (2.5.0-dev) Changes sizeof(worker_score) in scoreboard
>>> * 20130924.0 (2.5.0-dev) Add ap_errorlog_provider
>>> * 20130924.1 (2.5.0-dev) Add ap_proxy_connection_reusable()
>>> + * 20131112.0 (2.5.0-dev) Add parse_errorlog_arg to ap_errorlog_provider
>>> */
>>>
>>> #define MODULE_MAGIC_COOKIE 0x41503235UL /* "AP25" */
>>>
>>> #ifndef MODULE_MAGIC_NUMBER_MAJOR
>>> -#define MODULE_MAGIC_NUMBER_MAJOR 20130924
>>> +#define MODULE_MAGIC_NUMBER_MAJOR 20131112
>>> #endif
>>> #define MODULE_MAGIC_NUMBER_MINOR 1 /* 0...n */
>>>
>>>
>>
>> Why a major bump?
>>
>
> Correct me if I'm wrong, but my changes in that commit break binary compatibility for modules using the older error log provider API, so I thought I'm requested to bump major.
>
> Regards,
> Jan Kaluza
>
Re: svn commit: r1541029 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h
include/http_core.h modules/loggers/mod_syslog.c server/core.c
Posted by Jan Kaluža <jk...@redhat.com>.
On 11/12/2013 01:28 PM, Jim Jagielski wrote:
>
> On Nov 12, 2013, at 7:14 AM, jkaluza@apache.org wrote:
>
>> Author: jkaluza
>> Date: Tue Nov 12 12:14:50 2013
>> New Revision: 1541029
>>
>> URL: http://svn.apache.org/r1541029
>> Log:
>> Add parse_errorlog_arg callback to ap_errorlog_provider to allow providers
>> to check the ErrorLog argument. Implement this check in mod_syslog.
>>
>> Modified: httpd/httpd/trunk/include/ap_mmn.h
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_mmn.h?rev=1541029&r1=1541028&r2=1541029&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/include/ap_mmn.h (original)
>> +++ httpd/httpd/trunk/include/ap_mmn.h Tue Nov 12 12:14:50 2013
>> @@ -441,12 +441,13 @@
>> * 20130903.0 (2.5.0-dev) Changes sizeof(worker_score) in scoreboard
>> * 20130924.0 (2.5.0-dev) Add ap_errorlog_provider
>> * 20130924.1 (2.5.0-dev) Add ap_proxy_connection_reusable()
>> + * 20131112.0 (2.5.0-dev) Add parse_errorlog_arg to ap_errorlog_provider
>> */
>>
>> #define MODULE_MAGIC_COOKIE 0x41503235UL /* "AP25" */
>>
>> #ifndef MODULE_MAGIC_NUMBER_MAJOR
>> -#define MODULE_MAGIC_NUMBER_MAJOR 20130924
>> +#define MODULE_MAGIC_NUMBER_MAJOR 20131112
>> #endif
>> #define MODULE_MAGIC_NUMBER_MINOR 1 /* 0...n */
>>
>>
>
> Why a major bump?
>
Correct me if I'm wrong, but my changes in that commit break binary
compatibility for modules using the older error log provider API, so I
thought I'm requested to bump major.
Regards,
Jan Kaluza