You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "0lai0 (via GitHub)" <gi...@apache.org> on 2025/10/22 16:59:28 UTC

[PR] Migrate remaining providers to common.compat compatibility layer in http [airflow]

0lai0 opened a new pull request, #57089:
URL: https://github.com/apache/airflow/pull/57089

   This PR is a part of https://github.com/apache/airflow/issues/57018 about provider http.
   
   Replace version-specific conditional imports with apache/druid layer.
   This standardizes compatibility handling across Airflow 2.x and 3.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate http provider to common.compat [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #57089:
URL: https://github.com/apache/airflow/pull/57089#discussion_r2455262851


##########
providers/http/pyproject.toml:
##########
@@ -58,6 +58,7 @@ requires-python = ">=3.10"
 # After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
 dependencies = [
     "apache-airflow>=2.10.0",
+    "apache-airflow-providers-common-compat>=1.7.4",    # + TODO: bump to next version

Review Comment:
   ```suggestion
       "apache-airflow-providers-common-compat>=1.78.0"
   ```



##########
providers/http/pyproject.toml:
##########
@@ -58,6 +58,7 @@ requires-python = ">=3.10"
 # After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
 dependencies = [
     "apache-airflow>=2.10.0",
+    "apache-airflow-providers-common-compat>=1.7.4",    # + TODO: bump to next version

Review Comment:
   ```suggestion
       "apache-airflow-providers-common-compat>=1.78.0",
   ```



##########
providers/http/pyproject.toml:
##########
@@ -58,6 +58,7 @@ requires-python = ">=3.10"
 # After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
 dependencies = [
     "apache-airflow>=2.10.0",
+    "apache-airflow-providers-common-compat>=1.7.4",    # + TODO: bump to next version

Review Comment:
   ```suggestion
       "apache-airflow-providers-common-compat>=1.8.0",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate remaining providers to common.compat compatibility layer in http [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #57089:
URL: https://github.com/apache/airflow/pull/57089#issuecomment-3434466092

   PR title should be something like `Migrate http provider to `common.compat`` as mentioned in the guide on the GH issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate http provider to common.compat [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #57089:
URL: https://github.com/apache/airflow/pull/57089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate http provider to common.compat [airflow]

Posted by "0lai0 (via GitHub)" <gi...@apache.org>.
0lai0 commented on PR #57089:
URL: https://github.com/apache/airflow/pull/57089#issuecomment-3435063441

   Sure! Let me fix it. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate remaining providers to common.compat compatibility layer in http [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #57089:
URL: https://github.com/apache/airflow/pull/57089#issuecomment-3434467175

   Could you also take a look at failing tests plz


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org