You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "cziegeler (via GitHub)" <gi...@apache.org> on 2023/06/02 05:15:12 UTC
[GitHub] [sling-org-apache-sling-engine] cziegeler opened a new pull request, #36: SLING-11898 : Make patterns for access and request log configurable
cziegeler opened a new pull request, #36:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] krystiannowak commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable
Posted by "krystiannowak (via GitHub)" <gi...@apache.org>.
krystiannowak commented on code in PR #36:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1214017805
##########
src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java:
##########
@@ -71,16 +69,26 @@ public class RequestLogger {
})
int request_log_outputtype() default 0;
+ @AttributeDefinition(name = "Request Log Entry Format",
+ description = "The format of the request log. The request entry is "+
Review Comment:
@kwin @cziegeler Probably it would be some Sling counterpart of https://httpd.apache.org/docs/2.4/mod/mod_log_config.html#formats right? (for the ACCESS_LOG_FORMAT at least) so https://sling.apache.org/documentation/development/client-request-logging.html#ClientRequestLogging-LogFormatSpecification I guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] krystiannowak commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable
Posted by "krystiannowak (via GitHub)" <gi...@apache.org>.
krystiannowak commented on code in PR #36:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1214017805
##########
src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java:
##########
@@ -71,16 +69,26 @@ public class RequestLogger {
})
int request_log_outputtype() default 0;
+ @AttributeDefinition(name = "Request Log Entry Format",
+ description = "The format of the request log. The request entry is "+
Review Comment:
@kwin @cziegeler Probably it would be some counterpart of https://httpd.apache.org/docs/2.4/mod/mod_log_config.html#formats right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] kwin commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #36:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1213968900
##########
src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java:
##########
@@ -71,16 +69,26 @@ public class RequestLogger {
})
int request_log_outputtype() default 0;
+ @AttributeDefinition(name = "Request Log Entry Format",
+ description = "The format of the request log. The request entry is "+
Review Comment:
Can you add a documentation link explaining valid placeholders?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] cziegeler commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on code in PR #36:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1215299225
##########
src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java:
##########
@@ -71,16 +69,26 @@ public class RequestLogger {
})
int request_log_outputtype() default 0;
+ @AttributeDefinition(name = "Request Log Entry Format",
+ description = "The format of the request log. The request entry is "+
Review Comment:
I added the links (thanks @krystiannowak )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] cziegeler merged pull request #36: SLING-11898 : Make patterns for access and request log configurable
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler merged PR #36:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] krystiannowak commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable
Posted by "krystiannowak (via GitHub)" <gi...@apache.org>.
krystiannowak commented on code in PR #36:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1214017805
##########
src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java:
##########
@@ -71,16 +69,26 @@ public class RequestLogger {
})
int request_log_outputtype() default 0;
+ @AttributeDefinition(name = "Request Log Entry Format",
+ description = "The format of the request log. The request entry is "+
Review Comment:
@kwin @cziegeler Probably it would be some counterpart of https://httpd.apache.org/docs/2.4/mod/mod_log_config.html#formats right? (for the ACCESS_LOG_FORMAT at least)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org