You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bb...@apache.org on 2018/04/24 18:08:35 UTC

[1/2] mesos git commit: Removed `developers` from Java binding mesos.pom file.

Repository: mesos
Updated Branches:
  refs/heads/master c662048ae -> b95d68d63


Removed `developers` from Java binding mesos.pom file.

This field should list information about whom to contact for feedback
on specific pieces of the released Java package, which largely
overlaps with the Apache committer concept.

The information in this file in general duplicates information already
in `docs/committers.md` which is rendered on the Mesos project
website.  We also publish a link to the Mesos developers mailing list
with the bindings which should be sufficient to reach Mesos
committers.

Review: https://reviews.apache.org/r/66762


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/ac6b3834
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/ac6b3834
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/ac6b3834

Branch: refs/heads/master
Commit: ac6b3834f8beb6b9e12cccb61f92e57930c61e54
Parents: c662048
Author: Benjamin Bannier <bb...@apache.org>
Authored: Mon Apr 23 13:39:53 2018 +0200
Committer: Benjamin Bannier <bb...@apache.org>
Committed: Tue Apr 24 20:00:39 2018 +0200

----------------------------------------------------------------------
 src/java/mesos.pom.in | 47 ----------------------------------------------
 1 file changed, 47 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/ac6b3834/src/java/mesos.pom.in
----------------------------------------------------------------------
diff --git a/src/java/mesos.pom.in b/src/java/mesos.pom.in
index 418326b..318e986 100644
--- a/src/java/mesos.pom.in
+++ b/src/java/mesos.pom.in
@@ -32,53 +32,6 @@
       </otherArchives>
     </mailingList>
   </mailingLists>
-  <developers>
-    <developer>
-      <id>alig</id>
-      <name>Ali Ghodis</name>
-      <email>alig@apache.org</email>
-    </developer>
-    <developer>
-      <id>andyk</id>
-      <name>Andy Konwinski</name>
-      <email>andrew@apache.org</email>
-    </developer>
-    <developer>
-      <id>benh</id>
-      <name>Benjamin Hindman</name>
-      <email>benh@apache.org</email>
-    </developer>
-    <developer>
-      <id>bmahler</id>
-      <name>Benjamin Mahler</name>
-      <email>bmahler@apache.org</email>
-    </developer>
-    <developer>
-      <id>brenden</id>
-      <name>Brenden Matthews</name>
-      <email>brenden@apache.org</email>
-    </developer>
-    <developer>
-      <id>matei</id>
-      <name>Matei Zaharia</name>
-      <email>matei@apache.org</email>
-    </developer>
-    <developer>
-      <id>tmarshall</id>
-      <name>Thomas Marshall</name>
-      <email>tmarshall@apache.org</email>
-    </developer>
-    <developer>
-      <id>vinodkone</id>
-      <name>Vinod Kone</name>
-      <email>vinodkone@apache.org</email>
-    </developer>
-    <developer>
-      <id>woggle</id>
-      <name>Charles Reiss</name>
-      <email>woggle@apache.org</email>
-    </developer>
-  </developers>
   <dependencies>
     <dependency>
       <artifactId>protobuf-java</artifactId>


[2/2] mesos git commit: Improved support for move-only types in `hashmap`.

Posted by bb...@apache.org.
Improved support for move-only types in `hashmap`.

While it was already possible to create a `hashmap` over move-only
values, we still performed a copy in `put`, making it hard to
dynamically add elements with the expected stout semantics.

This patch relaxes the requirements on the value argument to `put` so
that instead of copyable we now only require move-constructible types.

Review: https://reviews.apache.org/r/66608/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/b95d68d6
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/b95d68d6
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/b95d68d6

Branch: refs/heads/master
Commit: b95d68d632caef49c9bba9e57493d2d853df0a87
Parents: ac6b383
Author: Benjamin Bannier <be...@mesosphere.io>
Authored: Tue Apr 24 20:02:09 2018 +0200
Committer: Benjamin Bannier <bb...@apache.org>
Committed: Tue Apr 24 20:02:09 2018 +0200

----------------------------------------------------------------------
 3rdparty/stout/include/stout/hashmap.hpp | 9 +++++++++
 1 file changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/b95d68d6/3rdparty/stout/include/stout/hashmap.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/hashmap.hpp b/3rdparty/stout/include/stout/hashmap.hpp
index 91085b8..698fa0f 100644
--- a/3rdparty/stout/include/stout/hashmap.hpp
+++ b/3rdparty/stout/include/stout/hashmap.hpp
@@ -101,6 +101,15 @@ public:
 
   // Inserts a key, value pair into the map replacing an old value
   // if the key is already present.
+  void put(const Key& key, Value&& value)
+  {
+    std::unordered_map<Key, Value, Hash, Equal>::erase(key);
+    std::unordered_map<Key, Value, Hash, Equal>::insert(
+        std::pair<Key, Value>(key, std::move(value)));
+  }
+
+  // Inserts a key, value pair into the map replacing an old value
+  // if the key is already present.
   void put(const Key& key, const Value& value)
   {
     std::unordered_map<Key, Value, Hash, Equal>::erase(key);