You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:57:11 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request #1619: Clarified application developer responsibility when using onException in native mode
aldettinger opened a new pull request #1619:
URL: https://github.com/apache/camel-quarkus/pull/1619
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1619: Clarified application developer responsibility when using onException in native mode
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1619:
URL: https://github.com/apache/camel-quarkus/pull/1619#discussion_r477192737
##########
File path: extensions/flatpack/deployment/src/main/java/org/apache/camel/quarkus/component/flatpack/deployment/FlatpackProcessor.java
##########
@@ -36,8 +34,4 @@ NativeImageResourceBuildItem registerNativeImageResources() {
return new NativeImageResourceBuildItem("net/sf/flatpack/xml/flatpack.dtd", "fpconvert.properties");
}
- @BuildStep
- ReflectiveClassBuildItem registerReflectiveClasses() {
- return new ReflectiveClassBuildItem(false, false, FlatpackException.class);
Review comment:
Maybe we should keep this?
If it's a class provided by Camel, then I see no harm in the extension registering it for reflection. If the exception types are provided by the user application, then it seems reasonable that they need to register them for reflection manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #1619: Clarified application developer responsibility when using onException in native mode
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #1619:
URL: https://github.com/apache/camel-quarkus/pull/1619#issuecomment-680782914
I'm pushing 2 commits at least for review. I'm happy to discuss rebasing them if preferred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger closed pull request #1619: Clarified application developer responsibility when using onException in native mode
Posted by GitBox <gi...@apache.org>.
aldettinger closed pull request #1619:
URL: https://github.com/apache/camel-quarkus/pull/1619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #1619: Clarified application developer responsibility when using onException in native mode
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #1619:
URL: https://github.com/apache/camel-quarkus/pull/1619#discussion_r477233308
##########
File path: extensions/flatpack/deployment/src/main/java/org/apache/camel/quarkus/component/flatpack/deployment/FlatpackProcessor.java
##########
@@ -36,8 +34,4 @@ NativeImageResourceBuildItem registerNativeImageResources() {
return new NativeImageResourceBuildItem("net/sf/flatpack/xml/flatpack.dtd", "fpconvert.properties");
}
- @BuildStep
- ReflectiveClassBuildItem registerReflectiveClasses() {
- return new ReflectiveClassBuildItem(false, false, FlatpackException.class);
Review comment:
There is just the cost of embedding this class while it may not be used. But, yeah there is not real harm and that could prevent camel-quarkus user to register this camel class. I'm gonna drop this commit and push locally.
Many thanks all for review :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org