[GitHub] [spark] cloud-fan commented on a change in pull request #32831: [SPARK-35685][SQL] Prompt recreating the view when there is an incompatible schema issue

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #32831:
URL: https://github.com/apache/spark/pull/32831#discussion_r661942379



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -846,6 +846,30 @@ class SessionCatalog(
     case None => fromCatalogTable(viewInfo.tableMeta, isTempView = true)
   }
 
+  private def buildViewDDL(metadata: CatalogTable, isTempView: Boolean): String = {
+    val isGlobalTemp = metadata.identifier.database.exists(_ == globalTempViewManager.database)
+    val viewType = if (isTempView && isGlobalTemp) {

Review comment:
       I think this only applies to the permanent view? We don't store temp view in the cataog.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org