You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by "lprimak (via GitHub)" <gi...@apache.org> on 2024/03/23 16:56:08 UTC

[PR] bugfix: remove exception from registered features [shiro]

lprimak opened a new pull request, #1384:
URL: https://github.com/apache/shiro/pull/1384

   <!--
   For Security Vulnerabilities, please email: security@shiro.apache.org
   For more details on how to report a vulnerablity see: https://www.apache.org/security/
   -->
   
   Following this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [GitHub issue](https://github.com/apache/shiro/issues) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a GitHub issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[#XXX] - Fixes bug in SessionManager`,
          where you replace `#XXX` with the appropriate GitHub issue. Best practice
          is to use the GitHub issue title in the pull request title and in the first line of the commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] add `fixes #XXX` if merging the PR should close a related issue.
    - [ ] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. 
    - [ ] Committers: Make sure a milestone is set on the PR
    
   Trivial changes like typos do not require a GitHub issue (javadoc, comments...). 
   In this case, just format the pull request title like `[DOC] - Add javadoc in SessionManager`.
    
   If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
   
   If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) 
   if you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [#1383] bugfix: remove exception from registered features [shiro]

Posted by "zenios (via GitHub)" <gi...@apache.org>.
zenios commented on code in PR #1384:
URL: https://github.com/apache/shiro/pull/1384#discussion_r1536677843


##########
support/jaxrs/src/main/java/org/apache/shiro/web/jaxrs/ShiroFeature.java:
##########
@@ -55,9 +53,7 @@ public class ShiroFeature implements Feature {
 
     @Override
     public boolean configure(FeatureContext context) {
-
         context.register(UnauthorizedExceptionExceptionMapper.class);
-        context.register(UnauthenticatedException.class);

Review Comment:
   UnauthenticatedException should be replaced with UnauthenticatedExceptionExceptionMapper.class.
   
   It is already inside the jar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [#1383] bugfix: fix exception mapper type from registered features [shiro]

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak merged PR #1384:
URL: https://github.com/apache/shiro/pull/1384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [#1383] bugfix: remove exception from registered features [shiro]

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1384:
URL: https://github.com/apache/shiro/pull/1384#discussion_r1536682479


##########
support/jaxrs/src/main/java/org/apache/shiro/web/jaxrs/ShiroFeature.java:
##########
@@ -55,9 +53,7 @@ public class ShiroFeature implements Feature {
 
     @Override
     public boolean configure(FeatureContext context) {
-
         context.register(UnauthorizedExceptionExceptionMapper.class);
-        context.register(UnauthenticatedException.class);

Review Comment:
   That is already there, just prior to the line you have here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [#1383] bugfix: remove exception from registered features [shiro]

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1384:
URL: https://github.com/apache/shiro/pull/1384#discussion_r1536682587


##########
support/jaxrs/src/main/java/org/apache/shiro/web/jaxrs/ShiroFeature.java:
##########
@@ -55,9 +53,7 @@ public class ShiroFeature implements Feature {
 
     @Override
     public boolean configure(FeatureContext context) {
-
         context.register(UnauthorizedExceptionExceptionMapper.class);
-        context.register(UnauthenticatedException.class);

Review Comment:
   NVM I see...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [#1383] bugfix: fix exception mapper type from registered features [shiro]

Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon commented on PR #1384:
URL: https://github.com/apache/shiro/pull/1384#issuecomment-2017312938

   @zenios good catch and thank you for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [#1383] bugfix: fix exception mapper type from registered features [shiro]

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1384:
URL: https://github.com/apache/shiro/pull/1384#issuecomment-2016932887

   Credit where credit is due, @zenios discovered this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org