[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6934: core: add JSON parser for ContentFile and FileScanTask

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on code in PR #6934:
URL: https://github.com/apache/iceberg/pull/6934#discussion_r1117532308


##########
api/src/main/java/org/apache/iceberg/FileScanTask.java:
##########
@@ -29,6 +29,13 @@ public interface FileScanTask extends ContentScanTask<DataFile>, SplittableScanT
    */
   List<DeleteFile> deletes();
 
+  /**
+   * Return the schema for this file scan task.
+   */
+  default Schema schema() {

Review Comment:
   this is needed so that `FileScanTaskParser` (added in this PR) can serialize the schema. Then during the deserialization part, schema can be pass into the constructor of `BaseFileScanTask`.
   
   Keep it at this level (not base interface) to limit the scope of change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org