[GitHub] [iceberg] kbendick commented on pull request #1491: [API][Types] Add a precondition null check for the constructor arg of PruneColumns, a SchemaVisitor

[GitBox <gi...@apache.org>]

kbendick commented on pull request #1491:
URL: https://github.com/apache/iceberg/pull/1491#issuecomment-699576667


   I found a few other places where there are `PruneColumns` classes that have the same behavior, i.e. not checking for null inside of the code in the class and not having a null precondition check in the constructor on the same field.
   
   I've updated those, but I need to take a closer look at a Python class of the same name as well as some classes related to Spark named `PruneColumnsWithoutReordering` and `PruneColumnsWithReordering`.
   
   Do you happen to know if Python typically null checks or is it possible that we assume things have gone through JVM code in certain cases and therefore don't add them? I'll check myself for cases, but I'd love it if you or someone could shed some insight onto that for Python inter-op. Possibly something I should ask on users@ or dev@? cc @rdblue 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org