[GitHub] [incubator-iceberg] rdblue commented on issue #438: Throw IllegalArgumentExcpetion exception in ReassignIds if field not found in sourceSchema

[GitBox <gi...@apache.org>]

rdblue commented on issue #438: Throw IllegalArgumentExcpetion exception in ReassignIds if field not found in sourceSchema
URL: https://github.com/apache/incubator-iceberg/pull/438#issuecomment-531310950
 
 
   +1
   
   Thanks for working on this, @shardulm94! I think in the long term, we will want to solve this slightly differently, by assigning new IDs to the schema when fields are missing. That way, we get the same schema and the [write compatibility check](https://github.com/apache/incubator-iceberg/blob/master/api/src/main/java/org/apache/iceberg/types/CheckCompatibility.java#L32) will generate the error messages. But this is certainly an improvement over a null pointer exception, so let's go ahead with this and we can make the larger update later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org