You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Sahoo (JIRA)" <ji...@apache.org> on 2010/03/01 14:32:05 UTC
[jira] Created: (FELIX-2150) URLStreamHandlerProxy.setURL may not
set query component correctly
URLStreamHandlerProxy.setURL may not set query component correctly
------------------------------------------------------------------
Key: FELIX-2150
URL: https://issues.apache.org/jira/browse/FELIX-2150
Project: Felix
Issue Type: Bug
Components: Framework
Affects Versions: felix-2.0.4
Reporter: Sahoo
On Mon, Mar 1, 2010 at 12:56 PM, Sahoo <Sa...@sun.com> wrote:
> > Hi,
> >
> > org.apache.felix.framework.URLStreamHandlerProxy has following methods:
> >
> > public void setURL(
> > URL url, String protocol, String host, int port, String authority,
> > String userInfo, String path, String query, String ref)
> > {
> > super.setURL(url, protocol, host, port, authority, userInfo, path,
> > query, ref);
> > }
> >
> > public void setURL(
> > URL url, String protocol, String host, int port, String file, String
> > ref)
> > {
> > super.setURL(url, protocol, host, port, null, null, file, null, ref);
> > }
> >
> >
> > There appears to be a *bug* in the latter method. It passes "file" as
> > "path." Should file not be brone into path and query components which would
> > have automatically happened if
> > super.setURL(url, protocol, host, port, file, ref) been called? Any
> > comments? I have not done any testing, just concluding based on code
> > inspection.
I agree, looks like a bug. It is not as bad as the path can be the
file as well but if you would call getQuery() on the resulting url it
will return null i think (even if you had a query). Could you create a
jira for this?
Thanks and regards,
Karl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-2150) URLStreamHandlerProxy.setURL may not
set query component correctly
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls reassigned FELIX-2150:
---------------------------------
Assignee: Karl Pauls
> URLStreamHandlerProxy.setURL may not set query component correctly
> ------------------------------------------------------------------
>
> Key: FELIX-2150
> URL: https://issues.apache.org/jira/browse/FELIX-2150
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.4
> Reporter: Sahoo
> Assignee: Karl Pauls
>
> On Mon, Mar 1, 2010 at 12:56 PM, Sahoo <Sa...@sun.com> wrote:
> > > Hi,
> > >
> > > org.apache.felix.framework.URLStreamHandlerProxy has following methods:
> > >
> > > public void setURL(
> > > URL url, String protocol, String host, int port, String authority,
> > > String userInfo, String path, String query, String ref)
> > > {
> > > super.setURL(url, protocol, host, port, authority, userInfo, path,
> > > query, ref);
> > > }
> > >
> > > public void setURL(
> > > URL url, String protocol, String host, int port, String file, String
> > > ref)
> > > {
> > > super.setURL(url, protocol, host, port, null, null, file, null, ref);
> > > }
> > >
> > >
> > > There appears to be a *bug* in the latter method. It passes "file" as
> > > "path." Should file not be brone into path and query components which would
> > > have automatically happened if
> > > super.setURL(url, protocol, host, port, file, ref) been called? Any
> > > comments? I have not done any testing, just concluding based on code
> > > inspection.
> I agree, looks like a bug. It is not as bad as the path can be the
> file as well but if you would call getQuery() on the resulting url it
> will return null i think (even if you had a query). Could you create a
> jira for this?
> Thanks and regards,
> Karl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2150) URLStreamHandlerProxy.setURL may not
set query component correctly
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls resolved FELIX-2150.
-------------------------------
Resolution: Fixed
I changed it to use the correct super method. Thanks.
> URLStreamHandlerProxy.setURL may not set query component correctly
> ------------------------------------------------------------------
>
> Key: FELIX-2150
> URL: https://issues.apache.org/jira/browse/FELIX-2150
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: framework-2.0.4, framework-2.0.5
> Reporter: Sahoo
> Assignee: Karl Pauls
> Fix For: framework-3.0.0
>
>
> On Mon, Mar 1, 2010 at 12:56 PM, Sahoo <Sa...@sun.com> wrote:
> > > Hi,
> > >
> > > org.apache.felix.framework.URLStreamHandlerProxy has following methods:
> > >
> > > public void setURL(
> > > URL url, String protocol, String host, int port, String authority,
> > > String userInfo, String path, String query, String ref)
> > > {
> > > super.setURL(url, protocol, host, port, authority, userInfo, path,
> > > query, ref);
> > > }
> > >
> > > public void setURL(
> > > URL url, String protocol, String host, int port, String file, String
> > > ref)
> > > {
> > > super.setURL(url, protocol, host, port, null, null, file, null, ref);
> > > }
> > >
> > >
> > > There appears to be a *bug* in the latter method. It passes "file" as
> > > "path." Should file not be brone into path and query components which would
> > > have automatically happened if
> > > super.setURL(url, protocol, host, port, file, ref) been called? Any
> > > comments? I have not done any testing, just concluding based on code
> > > inspection.
> I agree, looks like a bug. It is not as bad as the path can be the
> file as well but if you would call getQuery() on the resulting url it
> will return null i think (even if you had a query). Could you create a
> jira for this?
> Thanks and regards,
> Karl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2150) URLStreamHandlerProxy.setURL may not
set query component correctly
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls updated FELIX-2150:
------------------------------
Fix Version/s: framework-3.0.0
Affects Version/s: framework-2.0.5
Include this in 3.0
> URLStreamHandlerProxy.setURL may not set query component correctly
> ------------------------------------------------------------------
>
> Key: FELIX-2150
> URL: https://issues.apache.org/jira/browse/FELIX-2150
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: framework-2.0.4, framework-2.0.5
> Reporter: Sahoo
> Assignee: Karl Pauls
> Fix For: framework-3.0.0
>
>
> On Mon, Mar 1, 2010 at 12:56 PM, Sahoo <Sa...@sun.com> wrote:
> > > Hi,
> > >
> > > org.apache.felix.framework.URLStreamHandlerProxy has following methods:
> > >
> > > public void setURL(
> > > URL url, String protocol, String host, int port, String authority,
> > > String userInfo, String path, String query, String ref)
> > > {
> > > super.setURL(url, protocol, host, port, authority, userInfo, path,
> > > query, ref);
> > > }
> > >
> > > public void setURL(
> > > URL url, String protocol, String host, int port, String file, String
> > > ref)
> > > {
> > > super.setURL(url, protocol, host, port, null, null, file, null, ref);
> > > }
> > >
> > >
> > > There appears to be a *bug* in the latter method. It passes "file" as
> > > "path." Should file not be brone into path and query components which would
> > > have automatically happened if
> > > super.setURL(url, protocol, host, port, file, ref) been called? Any
> > > comments? I have not done any testing, just concluding based on code
> > > inspection.
> I agree, looks like a bug. It is not as bad as the path can be the
> file as well but if you would call getQuery() on the resulting url it
> will return null i think (even if you had a query). Could you create a
> jira for this?
> Thanks and regards,
> Karl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.