You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/02/13 21:34:51 UTC

Review Request 18094: HIVE-6339: Implement new JDK7 schema management APIs in java.sql.Connection

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18094/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-6339
    https://issues.apache.org/jira/browse/HIVE-6339


Repository: hive-git


Description
-------

Implement new JDK7 schema management APIs in java.sql.Connection.


Diffs
-----

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java e68a5a9 
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 13fc19b 

Diff: https://reviews.apache.org/r/18094/diff/


Testing
-------

Added new test case.


Thanks,

Prasad Mujumdar


Re: Review Request 18094: HIVE-6339: Implement new JDK7 schema management APIs in java.sql.Connection

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18094/#review34541
-----------------------------------------------------------



itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java
<https://reviews.apache.org/r/18094/#comment64651>

    It would be nice if these tab/spaces can be removed. Same below.


- Xuefu Zhang


On Feb. 14, 2014, 7:51 p.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18094/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 7:51 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6339
>     https://issues.apache.org/jira/browse/HIVE-6339
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Implement new JDK7 schema management APIs in java.sql.Connection.
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java e68a5a9 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 13fc19b 
> 
> Diff: https://reviews.apache.org/r/18094/diff/
> 
> 
> Testing
> -------
> 
> Added new test case.
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>


Re: Review Request 18094: HIVE-6339: Implement new JDK7 schema management APIs in java.sql.Connection

Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18094/
-----------------------------------------------------------

(Updated Feb. 14, 2014, 9:41 p.m.)


Review request for hive.


Changes
-------

Fixed whitespaces


Bugs: HIVE-6339
    https://issues.apache.org/jira/browse/HIVE-6339


Repository: hive-git


Description
-------

Implement new JDK7 schema management APIs in java.sql.Connection.


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java e68a5a9 
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 13fc19b 

Diff: https://reviews.apache.org/r/18094/diff/


Testing
-------

Added new test case.


Thanks,

Prasad Mujumdar


Re: Review Request 18094: HIVE-6339: Implement new JDK7 schema management APIs in java.sql.Connection

Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18094/
-----------------------------------------------------------

(Updated Feb. 14, 2014, 7:51 p.m.)


Review request for hive.


Changes
-------

Updated the patch to close the statement and resultset in the schema functions.


Bugs: HIVE-6339
    https://issues.apache.org/jira/browse/HIVE-6339


Repository: hive-git


Description
-------

Implement new JDK7 schema management APIs in java.sql.Connection.


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java e68a5a9 
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 13fc19b 

Diff: https://reviews.apache.org/r/18094/diff/


Testing
-------

Added new test case.


Thanks,

Prasad Mujumdar


Re: Review Request 18094: HIVE-6339: Implement new JDK7 schema management APIs in java.sql.Connection

Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18094/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 11:22 p.m.)


Review request for hive.


Changes
-------

The new JDBC APIs are not available in JDK6. Updated the test to invoke those via Hive specific interface.


Bugs: HIVE-6339
    https://issues.apache.org/jira/browse/HIVE-6339


Repository: hive-git


Description
-------

Implement new JDK7 schema management APIs in java.sql.Connection.


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java e68a5a9 
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 13fc19b 

Diff: https://reviews.apache.org/r/18094/diff/


Testing
-------

Added new test case.


Thanks,

Prasad Mujumdar