You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/10 17:27:41 UTC
[jira] [Commented] (ROCKETMQ-138) Add AuthenticationException class
to remove hard coded Aliyun authentication class
[ https://issues.apache.org/jira/browse/ROCKETMQ-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963224#comment-15963224 ]
ASF GitHub Bot commented on ROCKETMQ-138:
-----------------------------------------
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
It seems this pr is not merged yet, so I reopen it.
> Add AuthenticationException class to remove hard coded Aliyun authentication class
> ----------------------------------------------------------------------------------
>
> Key: ROCKETMQ-138
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-138
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-remoting
> Reporter: Jaskey Lam
> Assignee: Jaskey Lam
> Priority: Minor
>
> in NettyRemotingAbstract.java
> a hard coded aliyun class is used
> {code}
> catch (Throwable e) {
> if (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException"
> .equals(e.getClass().getCanonicalName())) {
> PLOG.error("process request exception", e);
> PLOG.error(cmd.toString());
> }
> {code}
> A common AuthenticationException should be added to identify Authentication failure. Developers can throw this exception so that remoting component can ignore it
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)