[jira] Commented: (DERBY-1956) Remove stale code from the statement classes in the client driver

["Bryan Pendleton (JIRA)" <de...@db.apache.org>]

    [ http://issues.apache.org/jira/browse/DERBY-1956?page=comments#action_12441749 ] 
            
Bryan Pendleton commented on DERBY-1956:
----------------------------------------

By looking at the content of the dead code, can you make a guess as to what feature it was in support of?

> Remove stale code from the statement classes in the client driver
> -----------------------------------------------------------------
>
>                 Key: DERBY-1956
>                 URL: http://issues.apache.org/jira/browse/DERBY-1956
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.3.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: 1956.diff, 1956.stat
>
>
> Statement and ParameterMetaData contain flags called escapedProcedureCallWithResult_. These flags might have had a function before, but now they are always false. They are used in many if-statements and make the code harder to read. Removing the flags and the code that is only executed when the flags are true, would simplify the code and make it more maintainable.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Commented: (DERBY-1956) Remove stale code from the statement classes in the client driver

[Daniel John Debrunner <dj...@apache.org>]

Bryan Pendleton (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/DERBY-1956?page=comments#action_12441749 ] 
>             
> Bryan Pendleton commented on DERBY-1956:
> ----------------------------------------
> 
> By looking at the content of the dead code, can you make a guess as to what feature it was in support of?

Cloudscape supported (in a non-standard way) direct calls to Java 
methods as "procedures" with out parameters. The code was very messy, 
trying to determine if a parameter was an IN or OUT parameter on the fly 
was awkward. The code might have been related to that, being able to 
call a Java method that was a "procedure" with out parameters and the 
Java method returned a value, e.g.

  {? = call some.method.inaclass.mymethod(?) }

The code was all replaced by standard SQL procedures and functions.
Dan.