You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Andreas Veithen (JIRA)" <ji...@apache.org> on 2012/05/15 23:39:11 UTC

[jira] [Resolved] (AXIOM-422) SOAPElement#checkParent not invoked consistently

     [ https://issues.apache.org/jira/browse/AXIOM-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved AXIOM-422.
-----------------------------------

    Resolution: Fixed
    
> SOAPElement#checkParent not invoked consistently
> ------------------------------------------------
>
>                 Key: AXIOM-422
>                 URL: https://issues.apache.org/jira/browse/AXIOM-422
>             Project: Axiom
>          Issue Type: Bug
>          Components: DOOM, LLOM
>    Affects Versions: 1.2.13
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.2.14
>
>
> SOAPElement (both the LLOM and DOOM variant) defines a mechanism that validates that each type of SOAP element can only be added in the right place (e.g. that a SOAPHeader can only be added as a child of a SOAPEnvelope). This is implemented by overriding the setParent method:
>     /** This has to be implemented by all the derived classes to check for the correct parent. */
>     protected abstract void checkParent(OMElement parent) throws SOAPProcessingException;
>     public void setParent(OMContainer element) {
>         super.setParent(element);
>         if (element instanceof OMElement) {
>             checkParent((OMElement) element);
>         }
>     }
> However, this code is not invoked in all cases:
> * In LLOM, it is invoked by insertSiblingAfter and insertSiblingBefore, but not by addChild.
> * In DOOM, it is never invoked because the setParent method is not overridden (although the checkParent methods are defined).
> * It is not invoked for SOAPHeaderBlock because SOAPHeaderBlock extends OMSourcedElement and the setParent method is not overridden (although the checkParent methods are present).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org