You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Muslimov Maxim (Created) (JIRA)" <ji...@apache.org> on 2012/02/21 12:23:34 UTC

[jira] [Created] (WW-3758) Please update commons-lang dep. to version 3.1

Please update commons-lang dep. to version 3.1
----------------------------------------------

                 Key: WW-3758
                 URL: https://issues.apache.org/jira/browse/WW-3758
             Project: Struts 2
          Issue Type: Improvement
          Components: Plugin - Tags
    Affects Versions: 2.3.1.2
         Environment: JRE/JDK 1.6.30, Tomcat 7.0
            Reporter: Muslimov Maxim
            Priority: Minor


Struts depends on old version of commons-lang package (2.5).
This package contains class StringEscapeUtils, which contains escapeHtml method.
This method escapes cyrillic symbols too. 
(In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)

So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
It's makes response body too large for russian-languaged sites.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212602#comment-13212602 ] 

Lukasz Lenart commented on WW-3758:
-----------------------------------

This change affects 88 files, poms and Java classes. The main reasons is that the package changed and few escape methods.
I've implemented the change and all the tests passed, instead using escapeHtml, I've switched to escapeHtml4.

Looks ok, but I would like to hear your opinion.
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Maurizio Cucchiara (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212642#comment-13212642 ] 

Maurizio Cucchiara commented on WW-3758:
----------------------------------------

Hi Lukasz,
why don't you attach the patch, such that everyone can test it?
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Muslimov Maxim (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213402#comment-13213402 ] 

Muslimov Maxim commented on WW-3758:
------------------------------------

Thanks, Lukasz!
I'll try this patch today.
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212645#comment-13212645 ] 

Lukasz Lenart commented on WW-3758:
-----------------------------------

ech.. the name is wrong but the content is correct ;-)
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Lukasz Lenart (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214422#comment-13214422 ] 

Lukasz Lenart edited comment on WW-3758 at 2/23/12 7:43 AM:
------------------------------------------------------------

What you mean by "wrong" ?

Commons-lang has a new groupId and artifactId, instead commons-lang must be org.apache.commons.


Anyway, I'll commit the changes
                
      was (Author: lukaszlenart):
    What you mean but "wrong" ?

Commons-lang has a new groupId and artifactId, instead commons-lang must be org.apache.commons.


Anyway, I'll commit the changes
                  
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Lukasz Lenart (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart reassigned WW-3758:
---------------------------------

    Assignee: Lukasz Lenart
    
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Lukasz Lenart (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart updated WW-3758:
------------------------------

    Attachment: WW-3631.patch

Good point :-)
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Lukasz Lenart (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart updated WW-3758:
------------------------------

    Fix Version/s: 2.3.2
    
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Lukasz Lenart (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart closed WW-3758.
-----------------------------

    Resolution: Fixed

Thanks for testing
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Maxim Muslimov 
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Muslimov Maxim (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214428#comment-13214428 ] 

Muslimov Maxim commented on WW-3758:
------------------------------------

"<groupId>org.apache.commons</groupId>
  <artifactId>commons-lang3</artifactId>
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">"

That is what i meant :)
Structure of XML document is corrupted.
Maybe this bug only happens with me.
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Muslimov Maxim (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214419#comment-13214419 ] 

Muslimov Maxim commented on WW-3758:
------------------------------------

"It's working!" :)
But after applying the patch %ROOT%/pom.xml file gets wrong structure.
First line becomes like 
"<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>".
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214422#comment-13214422 ] 

Lukasz Lenart commented on WW-3758:
-----------------------------------

What you mean but "wrong" ?

Commons-lang has a new groupId and artifactId, instead commons-lang must be org.apache.commons.


Anyway, I'll commit the changes
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214477#comment-13214477 ] 

Hudson commented on WW-3758:
----------------------------

Integrated in Struts2 #418 (See [https://builds.apache.org/job/Struts2/418/])
    WW-3758 - upgrade commons-lang to version 3.1 (Revision 1292705)

     Result = SUCCESS
lukaszlenart : 
Files : 
* /struts/struts2/trunk/apps/portlet/pom.xml
* /struts/struts2/trunk/apps/portlet/src/main/java/org/apache/struts2/portlet/example/spring/SpringAction.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/ActionError.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/ActionMessage.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/Anchor.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/DoubleSelect.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/Form.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/Property.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/ServletUrlRenderer.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/Text.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/ServletDispatcherResult.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/interceptor/validation/AnnotationValidationInterceptor.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/util/RegexPatternMatcher.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/util/StrutsUtil.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/views/jsp/ui/AbstractUITag.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/views/util/UrlHelper.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/views/velocity/VelocityManager.java
* /struts/struts2/trunk/core/src/test/java/org/apache/struts2/views/jsp/ui/ActionErrorTagTest.java
* /struts/struts2/trunk/core/src/test/java/org/apache/struts2/views/jsp/ui/ActionMessageTagTest.java
* /struts/struts2/trunk/plugins/codebehind/pom.xml
* /struts/struts2/trunk/plugins/codebehind/src/main/java/org/apache/struts2/config/ClasspathPackageProvider.java
* /struts/struts2/trunk/plugins/convention/pom.xml
* /struts/struts2/trunk/plugins/convention/src/main/java/org/apache/struts2/convention/DefaultActionNameBuilder.java
* /struts/struts2/trunk/plugins/convention/src/main/java/org/apache/struts2/convention/DefaultResultMapBuilder.java
* /struts/struts2/trunk/plugins/convention/src/main/java/org/apache/struts2/convention/PackageBasedActionConfigBuilder.java
* /struts/struts2/trunk/plugins/convention/src/main/java/org/apache/struts2/convention/SEOActionNameBuilder.java
* /struts/struts2/trunk/plugins/embeddedjsp/pom.xml
* /struts/struts2/trunk/plugins/embeddedjsp/src/main/java/org/apache/struts2/EmbeddedJSPResult.java
* /struts/struts2/trunk/plugins/embeddedjsp/src/main/java/org/apache/struts2/JSPLoader.java
* /struts/struts2/trunk/plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/JspCompilationContext.java
* /struts/struts2/trunk/plugins/embeddedjsp/src/test/java/org/apache/struts2/EmbeddedJSPResultTest.java
* /struts/struts2/trunk/plugins/embeddedjsp/src/test/resources/org/apache/struts2/scriptlet.jsp
* /struts/struts2/trunk/plugins/jasperreports/pom.xml
* /struts/struts2/trunk/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java
* /struts/struts2/trunk/plugins/javatemplates/pom.xml
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/Attributes.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/XHTMLTagSerializer.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/AbstractMessageListHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/AnchorHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/LabelHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/RadioHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/ResetHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/SelectHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/SubmitHandler.java
* /struts/struts2/trunk/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/TextAreaHandler.java
* /struts/struts2/trunk/plugins/json/pom.xml
* /struts/struts2/trunk/plugins/json/src/main/java/org/apache/struts2/json/JSONUtil.java
* /struts/struts2/trunk/plugins/json/src/main/java/org/apache/struts2/json/JSONValidationInterceptor.java
* /struts/struts2/trunk/plugins/json/src/main/java/org/apache/struts2/json/SerializationParams.java
* /struts/struts2/trunk/plugins/junit/src/main/java/org/apache/struts2/StrutsJUnit4TestCase.java
* /struts/struts2/trunk/plugins/osgi/pom.xml
* /struts/struts2/trunk/plugins/osgi/src/main/java/org/apache/struts2/osgi/BundleFreemarkerManager.java
* /struts/struts2/trunk/plugins/osgi/src/main/java/org/apache/struts2/osgi/FelixOsgiHost.java
* /struts/struts2/trunk/plugins/osgi/src/main/java/org/apache/struts2/osgi/OsgiConfigurationProvider.java
* /struts/struts2/trunk/plugins/oval/pom.xml
* /struts/struts2/trunk/plugins/oval/src/main/java/org/apache/struts2/oval/interceptor/OValValidationInterceptor.java
* /struts/struts2/trunk/plugins/portlet/pom.xml
* /struts/struts2/trunk/plugins/portlet/src/main/java/org/apache/struts2/components/PortletUrlRenderer.java
* /struts/struts2/trunk/plugins/portlet/src/main/java/org/apache/struts2/portlet/dispatcher/DispatcherServlet.java
* /struts/struts2/trunk/plugins/portlet/src/main/java/org/apache/struts2/portlet/dispatcher/Jsr168Dispatcher.java
* /struts/struts2/trunk/plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletStateInterceptor.java
* /struts/struts2/trunk/plugins/portlet/src/main/java/org/apache/struts2/portlet/result/PortletResult.java
* /struts/struts2/trunk/plugins/portlet/src/main/java/org/apache/struts2/portlet/util/PortletUrlHelper.java
* /struts/struts2/trunk/plugins/sitegraph/pom.xml
* /struts/struts2/trunk/plugins/sitemesh/src/main/java/org/apache/struts2/sitemesh/StrutsSiteMeshFactory.java
* /struts/struts2/trunk/plugins/spring/pom.xml
* /struts/struts2/trunk/plugins/spring/src/main/java/org/apache/struts2/spring/ClassReloadingXMLWebApplicationContext.java
* /struts/struts2/trunk/plugins/spring/src/main/java/org/apache/struts2/spring/StrutsSpringObjectFactory.java
* /struts/struts2/trunk/pom.xml
* /struts/struts2/trunk/xwork-core/pom.xml
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/DefaultActionProxy.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/config/entities/ActionConfig.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/config/providers/XmlHelper.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkBasicConverter.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/util/TextParseUtil.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/util/classloader/ReloadingClassLoader.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/util/finder/ClassFinder.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/util/finder/ResourceFinder.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/util/finder/UrlSet.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManager.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/RepopulateConversionErrorFieldValidatorSupport.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/ValidatorSupport.java

                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Maxim Muslimov 
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>         Attachments: WW-3631.patch
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira