You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/06/28 09:58:20 UTC
[Apache Bloodhound] #577: [Regression] Existing tickets are opened
via /newticket URL
#577: [Regression] Existing tickets are opened via /newticket URL
---------------------+---------------
Reporter: olemis | Owner:
Type: defect | Status: new
Priority: major | Version:
Resolution: |
---------------------+---------------
Regression of trac:#5022 detected after running the functional test suite
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/577>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #577: [Regression] Existing tickets are
opened via /newticket URL
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#577: [Regression] Existing tickets are opened via /newticket URL
---------------------------+-----------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: closed
Priority: blocker | Milestone: Release 7
Component: multiproduct | Version:
Resolution: fixed | Keywords: ticket
---------------------------+-----------------------
Comment (by olemis):
Replying to [comment:5 rjollos]:
> Replying to [comment:3 olemis]:
> > This seems to be a regression introduced by the changes applied for
#441 . Attached patch solves the issue, but maybe the check for
`/products` path prefix is not needed anymore.
>
> The check for `/products` in the path prefix has been in the module
since r1328476 / #3.
Yes, that's prior to bep:0003. It's been there since long time but had to
be updated after committing patches for #441 shifting the WSGI environment
to the left, which is what we have now in default hooks .
> I also can't see a reason for matching to `/products` in the path prefix
given the logic of `trac.ticket.web_ui.TicketModule.match_request`, but
I've left it for now since I don't understand it well enough to be sure.
If you find yourself confident it is no longer needed, we can do a follow-
on commit.
;)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/577#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #577: [Regression] Existing tickets are
opened via /newticket URL
Posted by Olemis Lang <ol...@gmail.com>.
On 6/28/13, Apache Bloodhound <de...@bloodhound.apache.org> wrote:
> #577: [Regression] Existing tickets are opened via /newticket URL
> ---------------------------+-----------------------
> Reporter: olemis | Owner: nobody
> Type: defect | Status: new
> Priority: blocker | Milestone: Release 7
> Component: multiproduct | Version:
> Resolution: | Keywords: ticket
> ---------------------------+-----------------------
> Changes (by olemis):
>
> * priority: major => blocker
> * keywords: => ticket
> * component: => multiproduct
> * owner: => nobody
> * milestone: => Release 7
>
>
This means that IMO this ticket should be resolved prior to Release 7 due date .
--
Regards,
Olemis.
Apache™ Bloodhound contributor
http://issues.apache.org/bloodhound
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #577: [Regression] Existing tickets are
opened via /newticket URL
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#577: [Regression] Existing tickets are opened via /newticket URL
---------------------------+-----------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: blocker | Milestone: Release 7
Component: multiproduct | Version:
Resolution: | Keywords: ticket
---------------------------+-----------------------
Changes (by olemis):
* priority: major => blocker
* keywords: => ticket
* component: => multiproduct
* owner: => nobody
* milestone: => Release 7
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/577#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #577: [Regression] Existing tickets are
opened via /newticket URL
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#577: [Regression] Existing tickets are opened via /newticket URL
---------------------------+-----------------------
Reporter: olemis | Owner: olemis
Type: defect | Status: accepted
Priority: blocker | Milestone: Release 7
Component: multiproduct | Version:
Resolution: | Keywords: ticket
---------------------------+-----------------------
Changes (by olemis):
* status: new => accepted
* owner: nobody => olemis
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/577#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #577: [Regression] Existing tickets are
opened via /newticket URL
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#577: [Regression] Existing tickets are opened via /newticket URL
---------------------------+-----------------------
Reporter: olemis | Owner:
Type: defect | Status: review
Priority: blocker | Milestone: Release 7
Component: multiproduct | Version:
Resolution: | Keywords: ticket
---------------------------+-----------------------
Changes (by olemis):
* owner: olemis =>
* status: accepted => review
Comment:
This seems to be a regression introduced by the changes applied for #441 .
Attached patch solves the issue, but maybe the check for `/products` path
prefix is not needed anymore. Details
{{{#!sh
$ hg qapplied
t577/t577_r1496958_newticket_id.diff
$ hg log -r qparent
changeset: 257:3c1e652d3ebc
tag: qparent
tag: svn-1496958
user: astaric@13f79535-47bb-0310-9956-ffa450edef68
date: Wed Jun 26 15:15:52 2013 +0000
summary: More robust handling of resources in timeline widget.
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/577#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #577: [Regression] Existing tickets are
opened via /newticket URL
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#577: [Regression] Existing tickets are opened via /newticket URL
---------------------------+-----------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: closed
Priority: blocker | Milestone: Release 7
Component: multiproduct | Version:
Resolution: fixed | Keywords: ticket
---------------------------+-----------------------
Changes (by rjollos):
* status: review => closed
* resolution: => fixed
Comment:
(In [1502405])
Prevent existing ticket from being opened via the `/newticket` URL. Fixes
#577.
This makes effective for the `ProductTicketModule` a change that was made
in Trac for the `TicketModule`, first introduced in t:#5022, backed-out
and then reintroduced in [t 6835]. Now existing tickets can't be opened
through a URL matching `/newticket\?id=\d+`, instead a `TracError` will be
raised. Patch by Olemis.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/577#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #577: [Regression] Existing tickets are
opened via /newticket URL
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#577: [Regression] Existing tickets are opened via /newticket URL
---------------------------+-----------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: review
Priority: blocker | Milestone: Release 7
Component: multiproduct | Version:
Resolution: | Keywords: ticket
---------------------------+-----------------------
Changes (by rjollos):
* owner: => rjollos
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/577#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #577: [Regression] Existing tickets are
opened via /newticket URL
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#577: [Regression] Existing tickets are opened via /newticket URL
---------------------------+-----------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: review
Priority: blocker | Milestone: Release 7
Component: multiproduct | Version:
Resolution: | Keywords: ticket
---------------------------+-----------------------
Comment (by rjollos):
Replying to [comment:3 olemis]:
> This seems to be a regression introduced by the changes applied for #441
. Attached patch solves the issue, but maybe the check for `/products`
path prefix is not needed anymore.
The check for `/products` in the path prefix has been in the module since
r1328476 / #3. I also can't see a reason for matching to `/products` in
the path prefix given the logic of
`trac.ticket.web_ui.TicketModule.match_request`, but I've left it for now
since I don't understand it well enough to be sure. If you find yourself
confident it is no longer needed, we can do a follow-on commit.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/577#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker