You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by BruceKuiLiu <gi...@git.apache.org> on 2017/10/11 12:07:01 UTC
[GitHub] camel pull request #2025: Fix the problem of using '+' and '+=' operators to...
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/camel/pull/2025
Fix the problem of using '+' and '+=' operators to concatenate strings a in a loop.
The method is building a String using concatenation in a loop.
In each iteration, the String is converted to a StringBuilder, appended to, and converted back to a String.
This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration.
Better performance can be obtained by using a StringBuilder explicitly.
http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/camel master6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2025.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2025
----
commit 9288e927965ec9702c8374777563d076e5e2afa9
Author: Kui LIU <br...@gmail.com>
Date: 2017-10-11T08:18:11Z
Fix the problem of using '+' and '+=' operators to concatenate stringa in a loop.
The method is building a String using concatenation in a loop.
In each iteration, the String is converted to a StringBuilder, appended to, and converted back to a String.
This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration.
Better performance can be obtained by using a StringBuilder explicitly.
http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION
----
---
[GitHub] camel pull request #2025: Fix the problem of using '+' and '+=' operators to...
Posted by BruceKuiLiu <gi...@git.apache.org>.
Github user BruceKuiLiu closed the pull request at:
https://github.com/apache/camel/pull/2025
---