You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Shi Wang <cn...@gmail.com> on 2016/11/03 23:50:07 UTC

Re: Review Request 53441: RANGER-686 Option to use custom "admin" username

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53441/
-----------------------------------------------------------

(Updated Nov. 3, 2016, 11:50 p.m.)


Review request for ranger, Don Bosco Durai and Madhan Neethiraj.


Repository: ranger


Description
-------

The solution is not specific to admin user.
We can use security-admin/scripts/changeusernameutil.py to change any user's username, as long as we know the old user name and password.
The usage is changeusernameutil.py <loginuserid> <password> <newusername>
If the old username(loginuserid) cannot be found in database or password not correct, or new username is the same with old username it will not proceed to change username.


Diffs
-----

  security-admin/scripts/changeusernameutil.py PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9885090 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java PRE-CREATION 
  src/main/assembly/admin-web.xml b06cdec 

Diff: https://reviews.apache.org/r/53441/diff/


Testing
-------

1. changeusernameutil.py admin admin wangshi --> user name update successfully.
2. changeusernameutil.py admin admin wangshi (after 1) --> username not found.
3. changeusernameutil.py wangshi admin wangshi --> newusername same with loginuserid
4. changeusernameutil.py wangshi wangshi admin --> password invalid.


Thanks,

Shi Wang


Re: Review Request 53441: RANGER-686 Option to use custom "admin" username

Posted by Shi Wang <cn...@gmail.com>.

> On Nov. 4, 2016, 3:43 a.m., Velmurugan Periasamy wrote:
> > -- Can you please update RANGER JIRA number in review request?
> > -- RANGER-686 seems to be not the right JIRA. Looks like this is related to RANGER-696

yes you're right, it is 696, thanks for point out!


- Shi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53441/#review154857
-----------------------------------------------------------


On Nov. 3, 2016, 11:50 p.m., Shi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53441/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 11:50 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai and Madhan Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The solution is not specific to admin user.
> We can use security-admin/scripts/changeusernameutil.py to change any user's username, as long as we know the old user name and password.
> The usage is changeusernameutil.py <loginuserid> <password> <newusername>
> If the old username(loginuserid) cannot be found in database or password not correct, or new username is the same with old username it will not proceed to change username.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/changeusernameutil.py PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9885090 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java PRE-CREATION 
>   src/main/assembly/admin-web.xml b06cdec 
> 
> Diff: https://reviews.apache.org/r/53441/diff/
> 
> 
> Testing
> -------
> 
> 1. changeusernameutil.py admin admin wangshi --> user name update successfully.
> 2. changeusernameutil.py admin admin wangshi (after 1) --> username not found.
> 3. changeusernameutil.py wangshi admin wangshi --> newusername same with loginuserid
> 4. changeusernameutil.py wangshi wangshi admin --> password invalid.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>


Re: Review Request 53441: RANGER-686 Option to use custom "admin" username

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53441/#review154857
-----------------------------------------------------------



-- Can you please update RANGER JIRA number in review request?
-- RANGER-686 seems to be not the right JIRA. Looks like this is related to RANGER-696

- Velmurugan Periasamy


On Nov. 3, 2016, 11:50 p.m., Shi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53441/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 11:50 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai and Madhan Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The solution is not specific to admin user.
> We can use security-admin/scripts/changeusernameutil.py to change any user's username, as long as we know the old user name and password.
> The usage is changeusernameutil.py <loginuserid> <password> <newusername>
> If the old username(loginuserid) cannot be found in database or password not correct, or new username is the same with old username it will not proceed to change username.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/changeusernameutil.py PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9885090 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java PRE-CREATION 
>   src/main/assembly/admin-web.xml b06cdec 
> 
> Diff: https://reviews.apache.org/r/53441/diff/
> 
> 
> Testing
> -------
> 
> 1. changeusernameutil.py admin admin wangshi --> user name update successfully.
> 2. changeusernameutil.py admin admin wangshi (after 1) --> username not found.
> 3. changeusernameutil.py wangshi admin wangshi --> newusername same with loginuserid
> 4. changeusernameutil.py wangshi wangshi admin --> password invalid.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>


Re: Review Request 53441: RANGER-696 Option to use custom "admin" username

Posted by Shi Wang <cn...@gmail.com>.

> On Nov. 4, 2016, 5:40 a.m., Don Bosco Durai wrote:
> > I did a quick review and it is looking good. I will let someone familiar with the code to sign off

Thanks Don.


- Shi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53441/#review154866
-----------------------------------------------------------


On Nov. 4, 2016, 4:42 a.m., Shi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53441/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 4:42 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai and Madhan Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The solution is not specific to admin user.
> We can use security-admin/scripts/changeusernameutil.py to change any user's username, as long as we know the old user name and password.
> The usage is changeusernameutil.py <loginuserid> <password> <newusername>
> If the old username(loginuserid) cannot be found in database or password not correct, or new username is the same with old username it will not proceed to change username.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/changeusernameutil.py PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9885090 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java PRE-CREATION 
>   src/main/assembly/admin-web.xml b06cdec 
> 
> Diff: https://reviews.apache.org/r/53441/diff/
> 
> 
> Testing
> -------
> 
> 1. changeusernameutil.py admin admin wangshi --> user name update successfully.
> 2. changeusernameutil.py admin admin wangshi (after 1) --> username not found.
> 3. changeusernameutil.py wangshi admin wangshi --> newusername same with loginuserid
> 4. changeusernameutil.py wangshi wangshi admin --> password invalid.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>


Re: Review Request 53441: RANGER-696 Option to use custom "admin" username

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53441/#review154866
-----------------------------------------------------------



I did a quick review and it is looking good. I will let someone familiar with the code to sign off

- Don Bosco Durai


On Nov. 4, 2016, 4:42 a.m., Shi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53441/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 4:42 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai and Madhan Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The solution is not specific to admin user.
> We can use security-admin/scripts/changeusernameutil.py to change any user's username, as long as we know the old user name and password.
> The usage is changeusernameutil.py <loginuserid> <password> <newusername>
> If the old username(loginuserid) cannot be found in database or password not correct, or new username is the same with old username it will not proceed to change username.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/changeusernameutil.py PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9885090 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java PRE-CREATION 
>   src/main/assembly/admin-web.xml b06cdec 
> 
> Diff: https://reviews.apache.org/r/53441/diff/
> 
> 
> Testing
> -------
> 
> 1. changeusernameutil.py admin admin wangshi --> user name update successfully.
> 2. changeusernameutil.py admin admin wangshi (after 1) --> username not found.
> 3. changeusernameutil.py wangshi admin wangshi --> newusername same with loginuserid
> 4. changeusernameutil.py wangshi wangshi admin --> password invalid.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>


Re: Review Request 53441: RANGER-696 Option to use custom "admin" username

Posted by Shi Wang <cn...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53441/
-----------------------------------------------------------

(Updated Nov. 4, 2016, 4:42 a.m.)


Review request for ranger, Don Bosco Durai and Madhan Neethiraj.


Summary (updated)
-----------------

RANGER-696 Option to use custom "admin" username


Repository: ranger


Description
-------

The solution is not specific to admin user.
We can use security-admin/scripts/changeusernameutil.py to change any user's username, as long as we know the old user name and password.
The usage is changeusernameutil.py <loginuserid> <password> <newusername>
If the old username(loginuserid) cannot be found in database or password not correct, or new username is the same with old username it will not proceed to change username.


Diffs
-----

  security-admin/scripts/changeusernameutil.py PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9885090 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java PRE-CREATION 
  src/main/assembly/admin-web.xml b06cdec 

Diff: https://reviews.apache.org/r/53441/diff/


Testing
-------

1. changeusernameutil.py admin admin wangshi --> user name update successfully.
2. changeusernameutil.py admin admin wangshi (after 1) --> username not found.
3. changeusernameutil.py wangshi admin wangshi --> newusername same with loginuserid
4. changeusernameutil.py wangshi wangshi admin --> password invalid.


Thanks,

Shi Wang