You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ah...@apache.org on 2020/04/17 16:14:47 UTC
[royale-compiler] branch develop updated: fix build
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
The following commit(s) were added to refs/heads/develop by this push:
new c61b3d0 fix build
c61b3d0 is described below
commit c61b3d0aa2159a902392307ebcbb53312eb93dce
Author: Alex Harui <ah...@apache.org>
AuthorDate: Fri Apr 17 09:14:31 2020 -0700
fix build
---
pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index a9cd598..53af767 100644
--- a/pom.xml
+++ b/pom.xml
@@ -144,7 +144,7 @@
<exclude>LICENSE*</exclude>
<exclude>NOTICE*</exclude>
<exclude>README*</exclude>
- <exclude>RELEASE_NOTES*</exclude>
+ <exclude>**/RELEASE_NOTES*</exclude>
<!-- Modules which are excluded from the build -->
<!-- FlashBuilder settings. frameworks/fb.properties contains Alex' path entries and should be removed -->
<exclude>fb.properties</exclude>
Re: [royale-compiler] branch develop updated: fix build
Posted by Christofer Dutz <ch...@c-ware.de>.
I wasn't referring to notice and licence files.
________________________________
Von: Alex Harui <ah...@adobe.com.INVALID>
Gesendet: Samstag, 18. April 2020 01:14
An: dev@royale.apache.org <de...@royale.apache.org>
Betreff: Re: [royale-compiler] branch develop updated: fix build
Please do not add an Apache header to the README or NOTICE (or the LICENSE). I'm pretty sure it is just a convention to not add the header. Headers are not a legal thing, they are just helpful signposts. A missing header does not change the copyright of the content. I would also argue that there isn't anything worth copyrighting in these files.
I thought Apache didn't like markdown files for README/RELEASE_NOTES. They look great on Github, but can be less readable in plain text. Maybe that's changed though.
I would prefer that there aren't lots of README/RELEASE_NOTES in the tree, so not sure we should recursively exclude all .md files.
My.2 cents,
-Alex
On 4/17/20, 11:13 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
Hi all.
So what is the difference between code and documentation?
I would say none.
So if I would be asked, I'd probably add the headers to all md, adoc, whatsoever files.
Chris
Am 17.04.20, 19:02 schrieb "Carlos Rovira" <ca...@apache.org>:
totally
El vie., 17 abr. 2020 a las 18:58, Yishay Weiss (<yi...@hotmail.com>)
escribió:
> Thanks. Doesn’t it make more sense to recursively exclude *.md files,
> something like
>
> <exclude>**/*.md</exclude>
>
> ?
>
> From: aharui@apache.org<ma...@apache.org>
> Sent: Friday, April 17, 2020 7:14 PM
> To: commits@royale.apache.org<ma...@royale.apache.org>
> Subject: [royale-compiler] branch develop updated: fix build
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C00d54869fbb64bc5383908d7e2fb1061%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227440263647213&sdata=FU01dhyhRS3Tows8tzsh6tRpewOT5EBKHsppBdmiy5s%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new c61b3d0 fix build
> c61b3d0 is described below
>
> commit c61b3d0aa2159a902392307ebcbb53312eb93dce
> Author: Alex Harui <ah...@apache.org>
> AuthorDate: Fri Apr 17 09:14:31 2020 -0700
>
> fix build
> ---
> pom.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pom.xml b/pom.xml
> index a9cd598..53af767 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -144,7 +144,7 @@
> <exclude>LICENSE*</exclude>
> <exclude>NOTICE*</exclude>
> <exclude>README*</exclude>
> - <exclude>RELEASE_NOTES*</exclude>
> + <exclude>**/RELEASE_NOTES*</exclude>
> <!-- Modules which are excluded from the build -->
> <!-- FlashBuilder settings. frameworks/fb.properties contains
> Alex' path entries and should be removed -->
> <exclude>fb.properties</exclude>
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C00d54869fbb64bc5383908d7e2fb1061%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227440263647213&sdata=IUBNebxRAN8NJke78spKrg%2FzGFCohJaOKTpdhlvfYbE%3D&reserved=0
Re: [royale-compiler] branch develop updated: fix build
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Please do not add an Apache header to the README or NOTICE (or the LICENSE). I'm pretty sure it is just a convention to not add the header. Headers are not a legal thing, they are just helpful signposts. A missing header does not change the copyright of the content. I would also argue that there isn't anything worth copyrighting in these files.
I thought Apache didn't like markdown files for README/RELEASE_NOTES. They look great on Github, but can be less readable in plain text. Maybe that's changed though.
I would prefer that there aren't lots of README/RELEASE_NOTES in the tree, so not sure we should recursively exclude all .md files.
My.2 cents,
-Alex
On 4/17/20, 11:13 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
Hi all.
So what is the difference between code and documentation?
I would say none.
So if I would be asked, I'd probably add the headers to all md, adoc, whatsoever files.
Chris
Am 17.04.20, 19:02 schrieb "Carlos Rovira" <ca...@apache.org>:
totally
El vie., 17 abr. 2020 a las 18:58, Yishay Weiss (<yi...@hotmail.com>)
escribió:
> Thanks. Doesn’t it make more sense to recursively exclude *.md files,
> something like
>
> <exclude>**/*.md</exclude>
>
> ?
>
> From: aharui@apache.org<ma...@apache.org>
> Sent: Friday, April 17, 2020 7:14 PM
> To: commits@royale.apache.org<ma...@royale.apache.org>
> Subject: [royale-compiler] branch develop updated: fix build
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C00d54869fbb64bc5383908d7e2fb1061%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227440263647213&sdata=FU01dhyhRS3Tows8tzsh6tRpewOT5EBKHsppBdmiy5s%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new c61b3d0 fix build
> c61b3d0 is described below
>
> commit c61b3d0aa2159a902392307ebcbb53312eb93dce
> Author: Alex Harui <ah...@apache.org>
> AuthorDate: Fri Apr 17 09:14:31 2020 -0700
>
> fix build
> ---
> pom.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pom.xml b/pom.xml
> index a9cd598..53af767 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -144,7 +144,7 @@
> <exclude>LICENSE*</exclude>
> <exclude>NOTICE*</exclude>
> <exclude>README*</exclude>
> - <exclude>RELEASE_NOTES*</exclude>
> + <exclude>**/RELEASE_NOTES*</exclude>
> <!-- Modules which are excluded from the build -->
> <!-- FlashBuilder settings. frameworks/fb.properties contains
> Alex' path entries and should be removed -->
> <exclude>fb.properties</exclude>
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C00d54869fbb64bc5383908d7e2fb1061%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227440263647213&sdata=IUBNebxRAN8NJke78spKrg%2FzGFCohJaOKTpdhlvfYbE%3D&reserved=0
Re: [royale-compiler] branch develop updated: fix build
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi all.
So what is the difference between code and documentation?
I would say none.
So if I would be asked, I'd probably add the headers to all md, adoc, whatsoever files.
Chris
Am 17.04.20, 19:02 schrieb "Carlos Rovira" <ca...@apache.org>:
totally
El vie., 17 abr. 2020 a las 18:58, Yishay Weiss (<yi...@hotmail.com>)
escribió:
> Thanks. Doesn’t it make more sense to recursively exclude *.md files,
> something like
>
> <exclude>**/*.md</exclude>
>
> ?
>
> From: aharui@apache.org<ma...@apache.org>
> Sent: Friday, April 17, 2020 7:14 PM
> To: commits@royale.apache.org<ma...@royale.apache.org>
> Subject: [royale-compiler] branch develop updated: fix build
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new c61b3d0 fix build
> c61b3d0 is described below
>
> commit c61b3d0aa2159a902392307ebcbb53312eb93dce
> Author: Alex Harui <ah...@apache.org>
> AuthorDate: Fri Apr 17 09:14:31 2020 -0700
>
> fix build
> ---
> pom.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pom.xml b/pom.xml
> index a9cd598..53af767 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -144,7 +144,7 @@
> <exclude>LICENSE*</exclude>
> <exclude>NOTICE*</exclude>
> <exclude>README*</exclude>
> - <exclude>RELEASE_NOTES*</exclude>
> + <exclude>**/RELEASE_NOTES*</exclude>
> <!-- Modules which are excluded from the build -->
> <!-- FlashBuilder settings. frameworks/fb.properties contains
> Alex' path entries and should be removed -->
> <exclude>fb.properties</exclude>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [royale-compiler] branch develop updated: fix build
Posted by Carlos Rovira <ca...@apache.org>.
totally
El vie., 17 abr. 2020 a las 18:58, Yishay Weiss (<yi...@hotmail.com>)
escribió:
> Thanks. Doesn’t it make more sense to recursively exclude *.md files,
> something like
>
> <exclude>**/*.md</exclude>
>
> ?
>
> From: aharui@apache.org<ma...@apache.org>
> Sent: Friday, April 17, 2020 7:14 PM
> To: commits@royale.apache.org<ma...@royale.apache.org>
> Subject: [royale-compiler] branch develop updated: fix build
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new c61b3d0 fix build
> c61b3d0 is described below
>
> commit c61b3d0aa2159a902392307ebcbb53312eb93dce
> Author: Alex Harui <ah...@apache.org>
> AuthorDate: Fri Apr 17 09:14:31 2020 -0700
>
> fix build
> ---
> pom.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pom.xml b/pom.xml
> index a9cd598..53af767 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -144,7 +144,7 @@
> <exclude>LICENSE*</exclude>
> <exclude>NOTICE*</exclude>
> <exclude>README*</exclude>
> - <exclude>RELEASE_NOTES*</exclude>
> + <exclude>**/RELEASE_NOTES*</exclude>
> <!-- Modules which are excluded from the build -->
> <!-- FlashBuilder settings. frameworks/fb.properties contains
> Alex' path entries and should be removed -->
> <exclude>fb.properties</exclude>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
RE: [royale-compiler] branch develop updated: fix build
Posted by Yishay Weiss <yi...@hotmail.com>.
Thanks. Doesn’t it make more sense to recursively exclude *.md files, something like
<exclude>**/*.md</exclude>
?
From: aharui@apache.org<ma...@apache.org>
Sent: Friday, April 17, 2020 7:14 PM
To: commits@royale.apache.org<ma...@royale.apache.org>
Subject: [royale-compiler] branch develop updated: fix build
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
The following commit(s) were added to refs/heads/develop by this push:
new c61b3d0 fix build
c61b3d0 is described below
commit c61b3d0aa2159a902392307ebcbb53312eb93dce
Author: Alex Harui <ah...@apache.org>
AuthorDate: Fri Apr 17 09:14:31 2020 -0700
fix build
---
pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index a9cd598..53af767 100644
--- a/pom.xml
+++ b/pom.xml
@@ -144,7 +144,7 @@
<exclude>LICENSE*</exclude>
<exclude>NOTICE*</exclude>
<exclude>README*</exclude>
- <exclude>RELEASE_NOTES*</exclude>
+ <exclude>**/RELEASE_NOTES*</exclude>
<!-- Modules which are excluded from the build -->
<!-- FlashBuilder settings. frameworks/fb.properties contains Alex' path entries and should be removed -->
<exclude>fb.properties</exclude>