You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (Created) (JIRA)" <ji...@apache.org> on 2012/03/12 18:41:37 UTC
[jira] [Created] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
If hive history file's directory doesn't exist don't crash
----------------------------------------------------------
Key: HIVE-2864
URL: https://issues.apache.org/jira/browse/HIVE-2864
Project: Hive
Issue Type: Improvement
Reporter: Kevin Wilfong
Assignee: Kevin Wilfong
Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
This will become more important once the directory becomes configurable, see:
https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233105#comment-13233105 ]
Hudson commented on HIVE-2864:
------------------------------
Integrated in Hive-trunk-h0.21 #1321 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1321/])
HIVE-2864 If hive history file's directory doesn't exist don't crash
(Kevin Wilfong via namit) (Revision 1302550)
Result = SUCCESS
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302550
Files :
* /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
> If hive history file's directory doesn't exist don't crash
> ----------------------------------------------------------
>
> Key: HIVE-2864
> URL: https://issues.apache.org/jira/browse/HIVE-2864
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.9.0
>
> Attachments: HIVE-2864.D2265.1.patch, HIVE-2864.D2265.2.patch
>
>
> Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
> This will become more important once the directory becomes configurable, see:
> https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227726#comment-13227726 ]
Phabricator commented on HIVE-2864:
-----------------------------------
njain has commented on the revision "HIVE-2864 [jira] If hive history file's directory doesn't exist don't crash".
INLINE COMMENTS
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:661 If these lines run into an error, the error will get propagated all
the way up.
Can you catch this error, and have a system.err... in case of that ?
Basically, the client should not die due to any problems with
history file.
REVISION DETAIL
https://reviews.facebook.net/D2265
> If hive history file's directory doesn't exist don't crash
> ----------------------------------------------------------
>
> Key: HIVE-2864
> URL: https://issues.apache.org/jira/browse/HIVE-2864
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2864.D2265.1.patch
>
>
> Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
> This will become more important once the directory becomes configurable, see:
> https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2864:
--------------------------------
Status: Patch Available (was: Open)
> If hive history file's directory doesn't exist don't crash
> ----------------------------------------------------------
>
> Key: HIVE-2864
> URL: https://issues.apache.org/jira/browse/HIVE-2864
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2864.D2265.1.patch
>
>
> Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
> This will become more important once the directory becomes configurable, see:
> https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2864:
-----------------------------------
Fix Version/s: 0.9.0
> If hive history file's directory doesn't exist don't crash
> ----------------------------------------------------------
>
> Key: HIVE-2864
> URL: https://issues.apache.org/jira/browse/HIVE-2864
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.9.0
>
> Attachments: HIVE-2864.D2265.1.patch, HIVE-2864.D2265.2.patch
>
>
> Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
> This will become more important once the directory becomes configurable, see:
> https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2864:
------------------------------
Attachment: HIVE-2864.D2265.2.patch
kevinwilfong updated the revision "HIVE-2864 [jira] If hive history file's directory doesn't exist don't crash".
Reviewers: JIRA, njain
Good call, Namit.
I now catch all errors thrown while trying to initialize the history file. If any errors are seen, the user is warned that history is unavailable for the session, and the error is displayed.
REVISION DETAIL
https://reviews.facebook.net/D2265
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
> If hive history file's directory doesn't exist don't crash
> ----------------------------------------------------------
>
> Key: HIVE-2864
> URL: https://issues.apache.org/jira/browse/HIVE-2864
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2864.D2265.1.patch, HIVE-2864.D2265.2.patch
>
>
> Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
> This will become more important once the directory becomes configurable, see:
> https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2864:
------------------------------
Attachment: HIVE-2864.D2265.1.patch
kevinwilfong requested code review of "HIVE-2864 [jira] If hive history file's directory doesn't exist don't crash".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2864
Displays a warning to the user if the directory for the history file does not exist, rather than crashing the session.
Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
This will become more important once the directory becomes configurable, see:
https://issues.apache.org/jira/browse/HIVE-1708
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2265
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5013/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> If hive history file's directory doesn't exist don't crash
> ----------------------------------------------------------
>
> Key: HIVE-2864
> URL: https://issues.apache.org/jira/browse/HIVE-2864
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2864.D2265.1.patch
>
>
> Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
> This will become more important once the directory becomes configurable, see:
> https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2864:
-----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed. Thanks Kevin
> If hive history file's directory doesn't exist don't crash
> ----------------------------------------------------------
>
> Key: HIVE-2864
> URL: https://issues.apache.org/jira/browse/HIVE-2864
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2864.D2265.1.patch, HIVE-2864.D2265.2.patch
>
>
> Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
> This will become more important once the directory becomes configurable, see:
> https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2864) If hive history file's directory
doesn't exist don't crash
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231323#comment-13231323 ]
Phabricator commented on HIVE-2864:
-----------------------------------
njain has accepted the revision "HIVE-2864 [jira] If hive history file's directory doesn't exist don't crash".
REVISION DETAIL
https://reviews.facebook.net/D2265
BRANCH
svn
> If hive history file's directory doesn't exist don't crash
> ----------------------------------------------------------
>
> Key: HIVE-2864
> URL: https://issues.apache.org/jira/browse/HIVE-2864
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2864.D2265.1.patch, HIVE-2864.D2265.2.patch
>
>
> Currently, if the history file's directory does not exist the Hive client crashes. Instead, since this is not a vital feature, it should just display a warning to the user and continue without it.
> This will become more important once the directory becomes configurable, see:
> https://issues.apache.org/jira/browse/HIVE-1708
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira