You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2012/05/02 13:06:57 UTC
[2/2] git commit: Strings#split(): avoid empty-array instantiation,
optimize empty-string case
Strings#split(): avoid empty-array instantiation, optimize empty-string case
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6da066ea
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6da066ea
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6da066ea
Branch: refs/heads/master
Commit: 6da066eaead05cab1566270ede6e81a1764a88fb
Parents: 15734a0
Author: Peter Ertl <pe...@apache.org>
Authored: Wed May 2 12:23:59 2012 +0200
Committer: Peter Ertl <pe...@apache.org>
Committed: Wed May 2 12:23:59 2012 +0200
----------------------------------------------------------------------
.../org/apache/wicket/util/string/Strings.java | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/6da066ea/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
index 25d70db..b561eff 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
@@ -60,6 +60,8 @@ public final class Strings
'A', 'B', 'C', 'D', 'E', 'F' };
private static final Pattern HTML_NUMBER_REGEX = Pattern.compile("&#\\d+;");
+
+ private static final String[] NO_STRINGS = new String[0];
static
{
@@ -827,9 +829,9 @@ public final class Strings
*/
public static String[] split(final String s, final char c)
{
- if (s == null)
+ if (s == null || s.length() == 0)
{
- return new String[0];
+ return NO_STRINGS;
}
final List<String> strings = new ArrayList<String>();
int pos = 0;