You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by dd...@apache.org on 2015/04/15 16:56:32 UTC
hbase git commit: HBASE-13460. Revise the MetaLookupPool
executor-related defaults (introduced in HBASE-13036).
Repository: hbase
Updated Branches:
refs/heads/master d6926629f -> d314f7d9e
HBASE-13460. Revise the MetaLookupPool executor-related defaults (introduced in HBASE-13036).
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/d314f7d9
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/d314f7d9
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/d314f7d9
Branch: refs/heads/master
Commit: d314f7d9e018ca8a67e0601a2de9b2bd0a08a5dc
Parents: d692662
Author: Devaraj Das <dd...@apache.org>
Authored: Wed Apr 15 07:56:25 2015 -0700
Committer: Devaraj Das <dd...@apache.org>
Committed: Wed Apr 15 07:56:25 2015 -0700
----------------------------------------------------------------------
.../hbase/client/ConnectionImplementation.java | 25 ++++++++++++--------
1 file changed, 15 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/d314f7d9/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
index bc2d51a..a51a4ac 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
@@ -79,6 +79,7 @@ import java.net.InetSocketAddress;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
+import java.util.concurrent.BlockingQueue;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.ExecutorService;
@@ -364,7 +365,7 @@ class ConnectionImplementation implements ClusterConnection, Closeable {
synchronized (this) {
if (batchPool == null) {
this.batchPool = getThreadPool(conf.getInt("hbase.hconnection.threads.max", 256),
- conf.getInt("hbase.hconnection.threads.core", 256), "-shared-");
+ conf.getInt("hbase.hconnection.threads.core", 256), "-shared-", null);
this.cleanupPool = true;
}
}
@@ -372,7 +373,8 @@ class ConnectionImplementation implements ClusterConnection, Closeable {
return this.batchPool;
}
- private ExecutorService getThreadPool(int maxThreads, int coreThreads, String nameHint) {
+ private ExecutorService getThreadPool(int maxThreads, int coreThreads, String nameHint,
+ BlockingQueue<Runnable> passedWorkQueue) {
// shared HTable thread executor not yet initialized
if (maxThreads == 0) {
maxThreads = Runtime.getRuntime().availableProcessors() * 8;
@@ -381,10 +383,13 @@ class ConnectionImplementation implements ClusterConnection, Closeable {
coreThreads = Runtime.getRuntime().availableProcessors() * 8;
}
long keepAliveTime = conf.getLong("hbase.hconnection.threads.keepalivetime", 60);
- LinkedBlockingQueue<Runnable> workQueue =
+ BlockingQueue<Runnable> workQueue = passedWorkQueue;
+ if (workQueue == null) {
+ workQueue =
new LinkedBlockingQueue<Runnable>(maxThreads *
conf.getInt(HConstants.HBASE_CLIENT_MAX_TOTAL_TASKS,
HConstants.DEFAULT_HBASE_CLIENT_MAX_TOTAL_TASKS));
+ }
ThreadPoolExecutor tpe = new ThreadPoolExecutor(
coreThreads,
maxThreads,
@@ -400,14 +405,14 @@ class ConnectionImplementation implements ClusterConnection, Closeable {
if (this.metaLookupPool == null) {
synchronized (this) {
if (this.metaLookupPool == null) {
- //The meta lookup can happen on replicas of the meta (if the appropriate configs
- //are enabled).In a replicated-meta setup, the number '3' is assumed as the max
- //number of replicas by default (unless it is configured to be of a higher value).
- //In a non-replicated-meta setup, only one thread would be active.
+ //Some of the threads would be used for meta replicas
+ //To start with, threads.max.core threads can hit the meta (including replicas).
+ //After that, requests will get queued up in the passed queue, and only after
+ //the queue is full, a new thread will be started
this.metaLookupPool = getThreadPool(
- conf.getInt("hbase.hconnection.meta.lookup.threads.max", 3),
- conf.getInt("hbase.hconnection.meta.lookup.threads.max.core", 3),
- "-metaLookup-shared-");
+ conf.getInt("hbase.hconnection.meta.lookup.threads.max", 128),
+ conf.getInt("hbase.hconnection.meta.lookup.threads.max.core", 10),
+ "-metaLookup-shared-", new LinkedBlockingQueue<Runnable>());
}
}
}