You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/01/18 14:20:01 UTC

Review Request 42457: Improved rakefile to allow for external .md file links.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42457/
-----------------------------------------------------------

Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-4384
    https://issues.apache.org/jira/browse/MESOS-4384


Repository: mesos


Description
-------

In addition also links with anchors (e.g. scheduler-http-api.md#recordio-response-format) will work now.


Diffs
-----

  site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 

Diff: https://reviews.apache.org/r/42457/diff/


Testing
-------

Tested with docker website container.
Additionally regex is nicely visualized here: https://regex101.com/r/zP6sH6/1


Thanks,

Joerg Schad


Re: Review Request 42457: Improved rakefile to allow for external .md file links.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42457/#review115085
-----------------------------------------------------------

Ship it!


Thanks for the regexp-tool-link -- very helpful for some of us -- certainly not me -- NO! -- NOT ME! -- ok, also me :)

- Till Toenshoff


On Jan. 18, 2016, 1:20 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42457/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 1:20 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-4384
>     https://issues.apache.org/jira/browse/MESOS-4384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In addition also links with anchors (e.g. scheduler-http-api.md#recordio-response-format) will work now.
> 
> 
> Diffs
> -----
> 
>   site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 
> 
> Diff: https://reviews.apache.org/r/42457/diff/
> 
> 
> Testing
> -------
> 
> Tested with docker website container.
> Additionally regex is nicely visualized here: https://regex101.com/r/zP6sH6/1
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 42457: Improved rakefile to allow for external .md file links.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42457/#review115048
-----------------------------------------------------------

Ship it!


Ship It!

- Neil Conway


On Jan. 18, 2016, 1:20 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42457/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 1:20 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-4384
>     https://issues.apache.org/jira/browse/MESOS-4384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In addition also links with anchors (e.g. scheduler-http-api.md#recordio-response-format) will work now.
> 
> 
> Diffs
> -----
> 
>   site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 
> 
> Diff: https://reviews.apache.org/r/42457/diff/
> 
> 
> Testing
> -------
> 
> Tested with docker website container.
> Additionally regex is nicely visualized here: https://regex101.com/r/zP6sH6/1
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 42457: Improved rakefile to allow for external .md file links.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42457/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 3:41 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-4384
    https://issues.apache.org/jira/browse/MESOS-4384


Repository: mesos


Description
-------

In addition also links with anchors (e.g. scheduler-http-api.md#recordio-response-format) will work now.


Diffs (updated)
-----

  site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 

Diff: https://reviews.apache.org/r/42457/diff/


Testing
-------

Tested with docker website container.
Additionally regex is nicely visualized here: https://regex101.com/r/zP6sH6/1


Thanks,

Joerg Schad