You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:24:20 UTC

[GitHub] [shardingsphere] jingshanglu opened a new pull request #5533: fix g4 file of mysql ddl

jingshanglu opened a new pull request #5533:
URL: https://github.com/apache/shardingsphere/pull/5533


   Ref #4683 .
   
   Changes proposed in this pull request:
   - fix g4 file of mysql ddl
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #5533: fix g4 file of mysql ddl

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5533:
URL: https://github.com/apache/shardingsphere/pull/5533#issuecomment-626683346


   ## Pull Request Test Coverage Report for [Build 11601](https://coveralls.io/builds/30698542)
   
   * **0** of **8**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.02%**) to **58.564%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/impl/MySQLDDLVisitor.java](https://coveralls.io/builds/30698542/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fmysql%2Fvisitor%2Fimpl%2FMySQLDDLVisitor.java#L273) | 0 | 8 | 0.0%
   <!-- | **Total:** | **0** | **8** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30698542/badge)](https://coveralls.io/builds/30698542) |
   | :-- | --: |
   | Change from base [Build 11599](https://coveralls.io/builds/30696196): |  -0.02% |
   | Covered Lines: | 11786 |
   | Relevant Lines: | 20125 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #5533: fix g4 file of mysql ddl

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5533:
URL: https://github.com/apache/shardingsphere/pull/5533#issuecomment-626681808


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5533?src=pr&el=h1) Report
   > Merging [#5533](https://codecov.io/gh/apache/shardingsphere/pull/5533?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b463438b381732ce2bc45981419a120154d090bc&el=desc) will **increase** coverage by `0.16%`.
   > The diff coverage is `11.11%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5533/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5533?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5533      +/-   ##
   ============================================
   + Coverage     54.89%   55.06%   +0.16%     
   - Complexity      422      423       +1     
   ============================================
     Files          1145     1145              
     Lines         20126    20125       -1     
     Branches       3673     3671       -2     
   ============================================
   + Hits          11048    11081      +33     
   + Misses         8384     8353      -31     
   + Partials        694      691       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5533?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sql/parser/mysql/visitor/impl/MySQLDDLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2ltcGwvTXlTUUxERExWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ngsphere/orchestration/core/common/CenterType.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbW1vbi9DZW50ZXJUeXBlLmphdmE=) | `100.00% <100.00%> (+100.00%)` | `0.00 <0.00> (ø)` | |
   | [...shardingjdbc/jdbc/core/context/RuntimeContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dC5qYXZh) | `87.80% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...rdingjdbc/api/ShardingSphereDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9hcGkvU2hhcmRpbmdTcGhlcmVEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ardingproxy/backend/schema/LogicSchemaFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9Mb2dpY1NjaGVtYUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../api/yaml/YamlShardingSphereDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9hcGkveWFtbC9ZYW1sU2hhcmRpbmdTcGhlcmVEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `35.71% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...mmon/metadata/schema/RuleSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL21ldGFkYXRhL3NjaGVtYS9SdWxlU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../OrchestrationShardingSphereDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2FwaS9PcmNoZXN0cmF0aW9uU2hhcmRpbmdTcGhlcmVEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../parser/EncryptDataSourceBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0VuY3J5cHREYXRhU291cmNlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `94.11% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9Db25maWdDZW50ZXIuamF2YQ==) | `85.36% <0.00%> (+12.19%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [5 more](https://codecov.io/gh/apache/shardingsphere/pull/5533/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5533?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5533?src=pr&el=footer). Last update [1ed73f0...e387382](https://codecov.io/gh/apache/shardingsphere/pull/5533?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org