You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 09:39:02 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7411: arm/phy62xx: fix compile warning on gcc-11.3 ('while' clause does not guard)
anchao opened a new pull request, #7411:
URL: https://github.com/apache/incubator-nuttx/pull/7411
## Summary
arm/phy62xx: fix compile warning on gcc-11.3 ('while' clause does not guard)
chip/flash.c: In function '_spif_read_status_reg_x': chip/flash.c:46:9: warning: this 'while' clause does not guard... [-Wmisleading-indentation]
46 | while ((AP_SPIF->fcmd &0x02)==0x02); \
| ^~~~~
chip/flash.c:128:3: note: in expansion of macro 'SPIF_STATUS_WAIT_IDLE'
128 | SPIF_STATUS_WAIT_IDLE(SPIF_WAIT_IDLE_CYC);
| ^~~~~~~~~~~~~~~~~~~~~
Signed-off-by: chao an <an...@xiaomi.com>
## Impact
N/A
## Testing
ci-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7411: arm/phy62xx: fix compile warning on gcc-11.3 ('while' clause does not guard)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7411:
URL: https://github.com/apache/incubator-nuttx/pull/7411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7411: arm/phy62xx: fix compile warning on gcc-11.3 ('while' clause does not guard)
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7411:
URL: https://github.com/apache/incubator-nuttx/pull/7411#discussion_r1003114740
##########
arch/arm/src/phy62xx/flash.c:
##########
@@ -43,7 +43,7 @@
#define SPIF_STATUS_WAIT_IDLE(n) \
do \
{ \
- while ((AP_SPIF->fcmd &0x02)==0x02); \
+ while ((AP_SPIF->fcmd &0x02)==0x02) \
Review Comment:
Are we sure that the fix isn't
```
while ((AP_SPIF->fcmd &0x02)==0x02) \
{} \
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7411: arm/phy62xx: fix compile warning on gcc-11.3 ('while' clause does not guard)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7411:
URL: https://github.com/apache/incubator-nuttx/pull/7411#issuecomment-1288955257
let's merge this patch to unblock ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org