You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/17 17:22:39 UTC
[GitHub] [pulsar-helm-chart] smazurov opened a new pull request #233: feat(certs): use actual v1 spec for certs
smazurov opened a new pull request #233:
URL: https://github.com/apache/pulsar-helm-chart/pull/233
### Motivation
In #204, api version of the cert resources was updated to v1. This was insufficient because `v1` has different spec from `v1alpha1`
This MR finishes the work that #204 and @lhotari started.
### Modifications
Changed the spec of certs to match v1 cert manager spec.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #233: feat(certs): use actual v1 spec for certs
Posted by GitBox <gi...@apache.org>.
lhotari edited a comment on pull request #233:
URL: https://github.com/apache/pulsar-helm-chart/pull/233#issuecomment-1054368281
@smazurov Thanks for the contribution. I created a PR to first revert #204 changes so that we have time to prepare a better solution for migrating to use `cert-manager.io/v1` api version in a backwards compatible way.
It seems that the backwards compatible migration might require more changes. For new installations (`{{- if .Release.IsInstall }}`) it should be fine to use the `cert-manager.io/v1` api version. For existing installations, I'm not exactly sure to handle the backwards compatibility.
cert-manager documentation about the deprecated api versions: https://cert-manager.io/docs/installation/upgrading/remove-deprecated-apis/#upgrading-existing-cert-manager-resources .
Any thoughts about this? /cc @michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on pull request #233: feat(certs): use actual v1 spec for certs
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #233:
URL: https://github.com/apache/pulsar-helm-chart/pull/233#issuecomment-1054368281
@smazurov Thanks for the contribution. I created a PR to first revert #204 changes so that we have time to prepare a better solution for migrating to use `cert-manager.io/v1` api version in a backwards compatible way.
It seems that the backwards compatible migration might require more changes. For new installations (`{{- if .Release.IsInstall }}`) it should be fine to use the `cert-manager.io/v1` api version. For existing installations, I'm not exactly sure to handle the backwards compatibility.
cert-manager documentation about the deprecated api versions: https://cert-manager.io/docs/installation/upgrading/remove-deprecated-apis/#upgrading-existing-cert-manager-resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] smazurov commented on pull request #233: feat(certs): use actual v1 spec for certs
Posted by GitBox <gi...@apache.org>.
smazurov commented on pull request #233:
URL: https://github.com/apache/pulsar-helm-chart/pull/233#issuecomment-1054586894
assuming kube is aware of both apis, upgrading is straightfoward. So the change is fine as long as the new spec for v1 is actually followed. Once cert-manager is upgraded to v1.6+, they dropped support for alpha versions, so it won't let you upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org