You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/01 13:44:04 UTC

[GitHub] [tvm] Mousius commented on pull request #9384: Arm(R) Ethos(TM)-U NPU Pooling operators support

Mousius commented on pull request #9384:
URL: https://github.com/apache/tvm/pull/9384#issuecomment-956245880


   > Thanks for the PR. @NicolaLancellotti
   > 
   > To get this PR moved forward, I would suggest adding tests for TypeReporter errors and lets follow up tests for other ICHECKs in P10 here : #9410.
   > 
   > @Mousius does that sound good ?
   
   One thing I'd suggest we don't move to another PR is adding tests for the other activation functions, as I think that's core to the functionality introduced here. Though given this has a green tick, if it's a relatively immediate follow up then that'd actually be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org