[GitHub] mgodave commented on issue #1315: Remove deprecated newConnect methods

[GitBox <gi...@apache.org>]

mgodave commented on issue #1315: Remove deprecated newConnect methods
URL: https://github.com/apache/incubator-pulsar/pull/1315#issuecomment-369718654
 
 
   ok, I could not see any place it was being used other than an old test.
   Feel free to close.
   
   On Thu, Mar 1, 2018 at 1:17 PM, Matteo Merli <no...@github.com>
   wrote:
   
   > @mgodave <https://github.com/mgodave> , the AuthMethod enum was used in
   > Pulsar before we realized that it was a problem to plug in an arbitrary
   > authentication plugin. For that we switched to "string" based identifier
   > well before open-sourcing Pulsar.
   >
   > The issue was, and I suspect that still is, that there are applications
   > running older Pulsar client version. The test was to ensure that this
   > client can still connect to new brokers. In fact, there's a specific check
   > for that enum in ServerCnx in order to maintain compatibility.
   >
   > ?
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pulsar/pull/1315#issuecomment-369717424>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAh9Fl-0MlOhrmUASpoj7Q2kxqZzjCMVks5taFdNgaJpZM4SY502>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services