You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/07/03 06:55:16 UTC

[PR] feat(deck-multi): migrate deck_multi chart to the v1 chart data API [superset]

rusackas opened a new pull request, #41730:
URL: https://github.com/apache/superset/pull/41730

   ### SUMMARY
   
   Tier 4 of #41714 (targets `remove-legacy-viz-pipeline`): migrate **deck.gl Multiple Layers (`deck_multi`)** off `explore_json` — the last `useLegacyApi` chart, and the last holdout in the deck.gl preset migration.
   
   `deck_multi` depended on `explore_json` twice: the container query (whose `viz.py` class fetched every sub-slice server-side just to hand back metadata and merged features) and each per-layer data fetch. Both move client-side:
   
   - New `Multi/buildQuery.ts` returns an **empty `queries` list** — the legacy `DeckGLMultiLayer.query_obj` was empty too; a new backend unit test pins that `ChartDataQueryContextSchema` accepts that shape.
   - `Multi.tsx` fetches sub-slice metadata via `GET /api/v1/chart/<id>` (bounded by `deck_slices`), and loads each layer through its own registered `buildQuery` → `POST /api/v1/chart/data` → registered `transformProps`, whose output payload is exactly what the layer generators consume. Legacy container payloads (cached) still short-circuit the metadata fetch.
   - Layer-scoped dashboard filtering (`layer_filter_scope`/`filter_data_mapping`), `dashboardId` and `parent_slice_id` propagation are unchanged — tests updated to assert them on the v1 POST payloads.
   - Known minor behavior notes: initial autozoom falls back to the saved viewport when no pre-merged container features exist (bounds previously came from the container payload), and dashboard filter badges no longer aggregate child-layer applied-filter metadata (the legacy container merged it server-side).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   No visual change in layer rendering; see autozoom note above.
   
   ### TESTING INSTRUCTIONS
   
   - `npm run test -- plugins/preset-chart-deckgl/src/Multi` — 30 tests pass (layer loading via registries, dashboardId/parent_slice_id propagation on POST payloads, layer visibility filtering, viewport handling).
   - `pytest tests/unit_tests/charts/data/test_empty_query_context.py` — empty-queries context accepted.
   - Manual: open a saved deck.gl Multiple Layers chart; network tab shows one `POST /api/v1/chart/data` per layer (no `/superset/explore_json/`); layer-scoped dashboard filters behave as before.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [x] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(deck-multi): migrate deck_multi chart to the v1 chart data API [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41730:
URL: https://github.com/apache/superset/pull/41730#issuecomment-4873475772

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(deck-multi): migrate deck_multi chart to the v1 chart data API [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41730:
URL: https://github.com/apache/superset/pull/41730#issuecomment-4873604078

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41730?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `57.69231%` with `22 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 63.88%. Comparing base ([`907b18a`](https://app.codecov.io/gh/apache/superset/commit/907b18a0d8b4d891b28f5370823cd74ac442d5ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7e98eb2`](https://app.codecov.io/gh/apache/superset/commit/7e98eb2a60aa996ef6381d15c7c0ac816c6a373c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on remove-legacy-viz-pipeline.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/41730?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...nd/plugins/preset-chart-deckgl/src/Multi/Multi.tsx](https://app.codecov.io/gh/apache/superset/pull/41730?src=pr&el=tree&filepath=superset-frontend%2Fplugins%2Fpreset-chart-deckgl%2Fsrc%2FMulti%2FMulti.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQtZGVja2dsL3NyYy9NdWx0aS9NdWx0aS50c3g=) | 61.22% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/41730?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...lugins/preset-chart-deckgl/src/Multi/buildQuery.ts](https://app.codecov.io/gh/apache/superset/pull/41730?src=pr&el=tree&filepath=superset-frontend%2Fplugins%2Fpreset-chart-deckgl%2Fsrc%2FMulti%2FbuildQuery.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQtZGVja2dsL3NyYy9NdWx0aS9idWlsZFF1ZXJ5LnRz) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/41730?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...end/plugins/preset-chart-deckgl/src/Multi/index.ts](https://app.codecov.io/gh/apache/superset/pull/41730?src=pr&el=tree&filepath=superset-frontend%2Fplugins%2Fpreset-chart-deckgl%2Fsrc%2FMulti%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQtZGVja2dsL3NyYy9NdWx0aS9pbmRleC50cw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/41730?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@                      Coverage Diff                       @@
   ##           remove-legacy-viz-pipeline   #41730      +/-   ##
   ==============================================================
   - Coverage                       63.91%   63.88%   -0.03%     
   ==============================================================
     Files                            2697     2698       +1     
     Lines                          148702   148734      +32     
     Branches                        34331    34339       +8     
   ==============================================================
   - Hits                            95040    95026      -14     
   - Misses                          51912    51958      +46     
     Partials                         1750     1750              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/41730/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/41730/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.19% <ø> (ø)` | |
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/41730/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.47% <57.69%> (-0.05%)` | :arrow_down: |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/41730/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.73% <ø> (ø)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/41730/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.64% <ø> (ø)` | |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/41730/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.48% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41730?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(deck-multi): migrate deck_multi chart to the v1 chart data API [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #41730:
URL: https://github.com/apache/superset/pull/41730


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org