You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/07 00:10:38 UTC

[GitHub] [incubator-superset] khtruong opened a new pull request #7463: fix: alter sql columns to long text

khtruong opened a new pull request #7463: fix: alter sql columns to long text
URL: https://github.com/apache/incubator-superset/pull/7463
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   There were issues executing long queries because we saved the strings to text columns in the query table. The queries would be truncated based on the storage size of the text column (i.e. Text in mysql can hold 65k characters - 64 KB). I have added a migration script to update the columns to hold longer strings.
   
   ### TEST PLAN
   Tested that the columns were long text columns in a mysql table after migration.
   
   ### REVIEWERS
   @betodealmeida @xtinec @DiggidyDave 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org