You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by huor <gi...@git.apache.org> on 2016/05/30 07:05:54 UTC
[GitHub] incubator-hawq pull request: HAWQ-766. Add feature test for partit...
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/680
HAWQ-766. Add feature test for partition using new feature test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq huor_partition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #680
----
commit 77e10940c1dee9f7dd7060eed4ad1b04bcd1f1c9
Author: Ruilong Huo <rh...@pivotal.io>
Date: 2016-05-30T07:04:48Z
HAWQ-766. Add feature test for partition using new feature test framework
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #680: HAWQ-766. Add feature test for partition using ne...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/680
\uff0b1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #680: HAWQ-766. Add feature test for partition u...
Posted by huor <gi...@git.apache.org>.
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/680
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #680: HAWQ-766. Add feature test for partition u...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/680#discussion_r65473433
--- Diff: src/test/feature/partition/test-partition.cpp ---
@@ -0,0 +1,19 @@
+#include "gtest/gtest.h"
+
+#include "lib/sql-util.h"
+
+
+class TestPartition: public ::testing::Test
+{
+ public:
+ TestPartition() {}
+ ~TestPartition() {}
+};
+
+TEST_F(TestPartition, TestPartitionNegativeAndBasics)
+{
+ SQLUtility util;
--- End diff --
based on https://github.com/apache/incubator-hawq/pull/683, please use `hawq::test:: SQLUtility` here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #680: HAWQ-766. Add feature test for partition u...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/680#discussion_r65473465
--- Diff: src/test/feature/partition/test-partition.cpp ---
@@ -0,0 +1,19 @@
+#include "gtest/gtest.h"
+
+#include "lib/sql-util.h"
--- End diff --
based on https://github.com/apache/incubator-hawq/pull/683, please write `lib/sql_util.h` here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #680: HAWQ-766. Add feature test for partition using ne...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/680
Close this pull request. Move the code review to https://github.com/apache/incubator-hawq/pull/686 due to manual merge of latest test framework refactor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---