[GitHub] [incubator-iceberg] edgarRd commented on a change in pull request #350: Add dropTableAndData to Catalog API

[GitBox <gi...@apache.org>]

edgarRd commented on a change in pull request #350: Add dropTableAndData to Catalog API
URL: https://github.com/apache/incubator-iceberg/pull/350#discussion_r311213522
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
 ##########
 @@ -120,6 +120,14 @@ default boolean tableExists(TableIdentifier identifier) {
    */
   boolean dropTable(TableIdentifier identifier);
 
+  /**
+   * Drop a table and remove all data and metadata files.
+   *
+   * @param identifier a table identifier
+   * @return true if the table was dropped, false if the table did not exist
+   */
+  boolean dropTableAndData(TableIdentifier identifier);
 
 Review comment:
   Is another call API method necessary (it has the same parameter) or could the behavior be represented by a boolean parameter in `dropTable`? I think `dropTableAndData` adds the assumption that `dropTable` does not delete the data but that is not specified in the `dropTable` docs either so it makes it confusing.
   
   I think avoiding another method call could help keeping the API simple. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org