You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "rnewson (via GitHub)" <gi...@apache.org> on 2025/12/03 12:23:24 UTC
[PR] ensure we decrement clients_requesting_changes [couchdb]
rnewson opened a new pull request, #5806:
URL: https://github.com/apache/couchdb/pull/5806
## Overview
ensure we decrement clients_requesting_changes even if the mochiweb process mediating the change request is killed by the client disconnect detector.
## Testing recommendations
follow procedure in https://github.com/apache/couchdb/issues/5802
## Related Issues or Pull Requests
https://github.com/apache/couchdb/issues/5802
## Checklist
- [x] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] Documentation changes were made in the `src/docs` folder
- [ ] Documentation changes were backported (separated PR) to affected branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ensure we decrement clients_requesting_changes [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #5806:
URL: https://github.com/apache/couchdb/pull/5806#issuecomment-3608337231
> continuous changes req is the only request that could in theory never end, whereas all the others do, so there's not as strong a need to count them in-flight (and, if those, why not everything?) but I don't feel that strongly against (or for).
yeah that makes sense, good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ensure we decrement clients_requesting_changes [couchdb]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on PR #5806:
URL: https://github.com/apache/couchdb/pull/5806#issuecomment-3607831917
continuous changes req is the only request that could in theory never end, whereas all the others do, so there's not as strong a need to count them in-flight (and, if those, why not everything?) but I don't feel that strongly against (or for).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org