You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/24 14:08:48 UTC
[GitHub] [maven-surefire] mthmulders opened a new pull request, #527: [SUREFIRE-2063] Allow consecutive spaces in argLine
mthmulders opened a new pull request, #527:
URL: https://github.com/apache/maven-surefire/pull/527
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[**SUREFIRE-2063**](https://issues.apache.org/jira/browse/SUREFIRE-2063)
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] pzygielo commented on a diff in pull request #527: [SUREFIRE-2063] Allow consecutive spaces in argLine
Posted by GitBox <gi...@apache.org>.
pzygielo commented on code in PR #527:
URL: https://github.com/apache/maven-surefire/pull/527#discussion_r857172458
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/DefaultForkConfiguration.java:
##########
@@ -251,9 +251,9 @@ private String interpolateArgLineWithPropertyExpressions()
}
@Nonnull
- private static String stripWhitespace( @Nonnull String argLine )
+ static String stripWhitespace( @Nonnull String argLine )
Review Comment:
With this access change I expected to see plenty of new UTs - but there is none committed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #527: [SUREFIRE-2063] Allow consecutive spaces in argLine
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on PR #527:
URL: https://github.com/apache/maven-surefire/pull/527#issuecomment-1108789885
@mthmulders
@pzygielo
Pls see the Jira https://issues.apache.org/jira/browse/SUREFIRE-2063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mthmulders commented on pull request #527: [SUREFIRE-2077] Allow consecutive spaces in argLine
Posted by GitBox <gi...@apache.org>.
mthmulders commented on PR #527:
URL: https://github.com/apache/maven-surefire/pull/527#issuecomment-1108908741
Let's have the conversation in JIRA, and when we have a decision, see if this implementation (still) makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #527: [SUREFIRE-2077] Allow consecutive spaces in argLine
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on PR #527:
URL: https://github.com/apache/maven-surefire/pull/527#issuecomment-1109032624
The initial problem was with tabs in CLI. This was fixed in [SUREFIRE-2063](https://issues.apache.org/jira/browse/SUREFIRE-2063) but it was not a real fix because it was not a real bug. It was not a real bug, it was just an improvement because the CLI and the platform can see the tab as collision, in JPMS to be concrete, and hard to understand for most of the common users. Even Maarten did not understand the issue immediately and he found the cause finally. So we make these treatments in order to come over the user troubles.
We can argue in a loop and everybody may have a different opinion about these details, how to espace white characters, and what characters should be considered, etc.
I believe that having \t and maybe new line characters is the issue which origins in the POM itself and not in this code. So, if it is this place of the root cause then it should be fixed there as well. Maybe some warning would be helpful, and maybe enough, just my thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mthmulders commented on a diff in pull request #527: [SUREFIRE-2063] Allow consecutive spaces in argLine
Posted by GitBox <gi...@apache.org>.
mthmulders commented on code in PR #527:
URL: https://github.com/apache/maven-surefire/pull/527#discussion_r857172932
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/DefaultForkConfiguration.java:
##########
@@ -251,9 +251,9 @@ private String interpolateArgLineWithPropertyExpressions()
}
@Nonnull
- private static String stripWhitespace( @Nonnull String argLine )
+ static String stripWhitespace( @Nonnull String argLine )
Review Comment:
Ah, well, I thought about doing that, but eventually refrained from it. I'll revert the visibility change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy merged pull request #527: [SUREFIRE-2077] Allow consecutive spaces in argLine
Posted by GitBox <gi...@apache.org>.
olamy merged PR #527:
URL: https://github.com/apache/maven-surefire/pull/527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org