[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5028: [RELAY] Remove kCompiler attr from ext mod

[GitBox <gi...@apache.org>]

zhiics commented on a change in pull request #5028: [RELAY] Remove kCompiler attr from ext mod
URL: https://github.com/apache/incubator-tvm/pull/5028#discussion_r397314736
 
 

 ##########
 File path: src/relay/backend/compile_engine.cc
 ##########
 @@ -627,6 +627,7 @@ class CompileEngineImpl : public CompileEngineNode {
         const tvm::tir::StringImmNode* symbol_name = ext_symbol.as<tvm::tir::StringImmNode>();
         CHECK(symbol_name) << "No external symbol is set for:\n" << AsText(src_func, false);
         auto gv = GlobalVar(symbol_name->value);
+        src_func = WithAttr(src_func, attr::kCompiler, tir::StringImmNode::make("default"));
 
 Review comment:
   Now you should not give it "default" but a null string ObjectRef, so that the returned value is not `defined`
   
   https://github.com/apache/incubator-tvm/blob/0a0e58bfa4c87b2cbff0be2b401da0b3a08fcfe8/include/tvm/ir/function.h#L99

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services