You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Zhangshoukui (via GitHub)" <gi...@apache.org> on 2024/10/09 07:50:56 UTC

[PR] Fix to compile parameters not taking effect When cmake version is greater than 3.18 [nuttx]

Zhangshoukui opened a new pull request, #13977:
URL: https://github.com/apache/nuttx/pull/13977

   ## Summary
   Fix to compile parameters not taking effect When cmake version is greater than 3.18
   https://cmake.org/cmake/help/latest/command/set_source_files_properties.html
   
   New in version 3.18: By default, source file properties are only visible to targets added in the same directory (CMakeLists.txt). Visibility can be set in other directory scopes using one or both of the following options:
   
   DIRECTORY <dirs>...
   The source file properties will be set in each of the <dirs> directories' scopes. CMake must already know about each of these source directories, either by having added them through a call to [add_subdirectory()](https://cmake.org/cmake/help/latest/command/add_subdirectory.html#command:add_subdirectory) or it being the top level source directory. Relative paths are treated as relative to the current source directory.
   ## Impact
   flag configuration does not take effect when the cmake version is greater than 3.18
   ## Testing
   Local test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix to compile parameters not taking effect When cmake version is greater than 3.18 [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #13977:
URL: https://github.com/apache/nuttx/pull/13977#issuecomment-2401627571

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   This Pull Request appears to **partially meet** NuttX's requirements. 
   
   **Strengths:**
   
   * **Clear Problem Statement:** The summary clearly identifies the issue (compile parameters not taking effect with CMake > 3.18) and links to the relevant CMake documentation.
   * **Impact is Addressed:**  The impact section highlights the specific consequence (flag configuration failure). 
   
   **Areas for Improvement:**
   
   * **Missing Details in Summary:**
       * **Functional Change:**  Be more specific about *what part* of the code is changed to address the CMake issue. 
       * **How it Works:**  Provide a brief technical explanation of your solution. *How* does your fix ensure compile parameters take effect?
       * **Issue References:**  If applicable, include links to related NuttX issues.
   * **Incomplete Impact Assessment:**
       * **User Impact:**  Will users need to make any changes (e.g., CMake minimum version)?
       * **Build Impact:**  Does your fix affect the build process itself (e.g., new dependencies)?
       * **Other Impacts:**  While this fix might not directly impact hardware, documentation, security, or compatibility, it's good practice to explicitly state "NO" for these if they don't apply.
   * **Insufficient Testing Information:**
       * **Build Hosts:** List the specific operating systems, architectures, and compilers you used for testing.
       * **Target Details:** Provide the architecture, board, and configurations of your test targets.
       * **Testing Logs:**  Instead of "Local test," include relevant snippets from your build logs (before and after the fix) that demonstrate the issue and its resolution.
   
   **Recommendation:**
   
   Expand the Summary, Impact, and Testing sections with the missing details to provide a more comprehensive view of the changes and their effects. This will make it easier for reviewers to understand and approve your Pull Request. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix to compile parameters not taking effect When cmake version is greater than 3.18 [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13977:
URL: https://github.com/apache/nuttx/pull/13977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org