[GitHub] [madlib] orhankislal commented on a change in pull request #574: Build: Use dynamic_library_path for module pathname

[GitBox <gi...@apache.org>]

orhankislal commented on a change in pull request #574:
URL: https://github.com/apache/madlib/pull/574#discussion_r759700395



##########
File path: src/madpack/madpack.py
##########
@@ -1409,16 +1419,41 @@ def main(argv):
         else:
             maddir_conf = maddir + "/config"
 
-        global maddir_lib
-        if portid == 'greenplum' and \
-           os.path.islink(maddir + "/../../../lib/postgresql/libmadlib.so"):
-           maddir_lib = '$libdir/libmadlib.so'
-        elif os.path.isfile(maddir + "/ports/" + portid + "/" + dbver +
+        global madlib_library_path
+        # Local build at ~/workspace/madlib/build/
+        if os.path.isfile(maddir_abs + "/src/ports/" + portid + "/" + dbver +

Review comment:
       The `If` part is under the maddir_abs folder but the `elif` part is outside (since we want to make sure we are looking at the Current folder, not Versions). This makes glob complicated because we don't want to search outside the madlib folder accidentally. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org