You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/06/02 22:37:00 UTC
[jira] [Commented] (PARQUET-2301) Add missing argument in ParquetRewriter logging
[ https://issues.apache.org/jira/browse/PARQUET-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728881#comment-17728881 ]
ASF GitHub Bot commented on PARQUET-2301:
-----------------------------------------
yihua opened a new pull request, #1104:
URL: https://github.com/apache/parquet-mr/pull/1104
Cherry-pick #1096 to `parquet-1.13.x` branch.
### Jira
- [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title: https://issues.apache.org/jira/browse/PARQUET-2301
### Tests
- [x] Already covered by existing tests in `ParquetRewriterTest`
Before this PR, the logging message puts the output path directly after `input files`, which is confusing:
```
2023-05-24 17:25:49 INFO ParquetRewriter - Start rewriting 1 input files /var/folders/60/wk8qzx310fd32b2dp7mhzvdc0000gn/T/test6036085754599645014/test.parquet to {}
```
After this PR, the log is fixed:
```
2023-05-24 17:22:16 INFO ParquetRewriter - Start rewriting 1 input file(s) [/var/folders/60/wk8qzx310fd32b2dp7mhzvdc0000gn/T/test1323432776204209385/test.parquet] to /var/folders/60/wk8qzx310fd32b2dp7mhzvdc0000gn/T/test6904487786327536358/test.parquet
```
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] No documentation needed
> Add missing argument in ParquetRewriter logging
> ------------------------------------------------
>
> Key: PARQUET-2301
> URL: https://issues.apache.org/jira/browse/PARQUET-2301
> Project: Parquet
> Issue Type: Improvement
> Affects Versions: 1.13.0
> Reporter: Ethan Guo
> Priority: Major
> Fix For: 1.14.0
>
>
> The logging statement misses one argument
> {code:java}
> LOG.info("Start rewriting {} input files {} to {}", inputFiles.size(), outPath); {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)