[GitHub] [nifi] tpalfy commented on a change in pull request #4303: NIFI-7312: Enable search in variable registry of root process group

[GitBox <gi...@apache.org>]

tpalfy commented on a change in pull request #4303:
URL: https://github.com/apache/nifi/pull/4303#discussion_r432535909



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/controller/ControllerSearchServiceRegressionTest.java
##########
@@ -265,6 +265,13 @@ public void testTextOmniMatch() {
             "Variable Value: processgroup1_variable2_value_omniMatch"
         );
 
+        final ComponentSearchResultDTO rootProcessGroupResult = getSimpleResult(ROOT_PROCESSOR_GROUP_ID, ROOT_PROCESSOR_GROUP_NAME,
+                ROOT_PROCESSOR_GROUP_ID,
+                null,
+                null,
+                "Comments: root_no_find_omniMatch"

Review comment:
       The idea was that it's called "...no_find..." because even though it contains the search keyword ("omniMatch") according to the business logic, it shouldn't be found.
   
   Now that this logic has been changed and we _do_ search in the root process group comments (among others) we might want to change it to `"root_comments_omnitMatch"`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org